Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release #1166

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

busunkim96
Copy link
Contributor

Allow google-api-core<3.0.0dev on previous release of library. This will be followed by a release PR.

@busunkim96 busunkim96 requested review from a team, tswast and parthea and removed request for a team March 10, 2022 22:25
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 10, 2022
@busunkim96 busunkim96 changed the title chore(deps): allow google-api-core v2 on v1 release chore(deps): allow google-api-core, google-cloud-core v2 on v1 release Mar 10, 2022
tswast and others added 2 commits March 12, 2022 18:59
`google-cloud-core` version 1.4.2 populates `prettyPrint=false` by
default. Update the connection tests to expect a value for
`prettyPrint`.
@parthea parthea changed the title chore(deps): allow google-api-core, google-cloud-core v2 on v1 release fix(deps): require google-api-core >= 1.31.5, >= 2.3.2 on v1 release Mar 14, 2022
…ddress (#942)

* chore: update system tests and samples to use and @google.com email address

* Add group prefix

* fixed access entry some more
@busunkim96 busunkim96 requested a review from a team as a code owner March 14, 2022 20:05
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failures look like a conflict between new pandas and old pyarrow, but probably not worth investigating further.

@tswast tswast merged commit 34d9bec into v1 Mar 25, 2022
@tswast tswast deleted the v1-api-core-pin branch March 25, 2022 21:19
@busunkim96 busunkim96 added the release-please:force-run To run release-please label Apr 4, 2022
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants