Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(samples): add create_table_clustered code snippet #291

Merged

Conversation

@ryanyuan
Copy link
Contributor

@ryanyuan ryanyuan commented Oct 2, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #290 馃

@ryanyuan ryanyuan requested review from as code owners Oct 2, 2020
@ryanyuan ryanyuan requested a review from engelke Oct 2, 2020
@google-cla google-cla bot added the cla: yes label Oct 2, 2020
Copy link
Contributor

@tswast tswast left a comment

Thanks for the contribution! Could you also add a test file to the samples directory?

Loading

@ryanyuan
Copy link
Contributor Author

@ryanyuan ryanyuan commented Oct 3, 2020

Thanks for the contribution! Could you also add a test file to the samples directory?

Done.

PTAL. Cheers! @tswast

Loading

tswast
tswast approved these changes Oct 5, 2020
engelke
engelke approved these changes Oct 6, 2020
Copy link

@engelke engelke left a comment

LGTM

Loading

@tswast tswast merged commit d1eb8b3 into googleapis:master Oct 6, 2020
9 checks passed
Loading
@tswast
Copy link
Contributor

@tswast tswast commented Oct 6, 2020

@ryanyuan Thanks so much for the contribution. Just sent internal change 335690842 out for review to get this added to the cloud.google.com docs.

Loading

@ryanyuan
Copy link
Contributor Author

@ryanyuan ryanyuan commented Oct 6, 2020

@ryanyuan Thanks so much for the contribution. Just sent internal change 335690842 out for review to get this added to the cloud.google.com docs.

Awesome! Thank you @tswast

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants