Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary dependency on libcst #308

Merged
merged 3 commits into from Oct 8, 2020

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Oct 7, 2020

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #302 馃

@tswast tswast requested a review from a team October 7, 2020 16:14
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 7, 2020
@tswast
Copy link
Contributor Author

tswast commented Oct 7, 2020

Ran synthtool locally and verified that the "fixup" script stays excluded.

@tswast tswast merged commit c055930 into googleapis:master Oct 8, 2020
8 checks passed
Remove `libcst` as a required dependency from python libraries automation moved this from In progress to Done Oct 8, 2020
@tswast tswast deleted the issue302-libcst branch October 8, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Development

Successfully merging this pull request may close these issues.

google-cloud-bigquery not compatible with pandas-gbq error
2 participants