Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add sample to run DML query #591

merged 3 commits into from Apr 13, 2021


Copy link

@tswast tswast commented Apr 6, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal issue 178085085

@tswast tswast requested a review from as a code owner Apr 6, 2021
@tswast tswast requested review from dinagraves and removed request for Apr 6, 2021
Copy link

@snippet-bot snippet-bot bot commented Apr 6, 2021

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment


@tswast tswast requested review from and tmatsuo and removed request for dinagraves and Apr 7, 2021
Copy link
Contributor Author

@tswast tswast commented Apr 7, 2021

Re-assigning based on OOO


Copy link

@tseaver tseaver left a comment



dataset, delete_contents=True, not_found_ok=True

Copy link

@tmatsuo tmatsuo Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cleanup code looks great. Since dataset has created property so technically there's no need to have timestamp in the resource name, but it's also good when we manually check the resources.

Only concern is this code might fail and the test fails too. It might annoy us. If it annoys us too much, maybe we can consider ignoring failure here.


Copy link
Contributor Author

@tswast tswast Apr 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The not_found_ok will ignore the most common error of 404. Other than that, I've not found the delete_dataset operation to be all that flaky with the default retry options.


@tswast tswast merged commit ff2ec3a into googleapis:master Apr 13, 2021
11 checks passed
@tswast tswast deleted the b178085085-bigquery_update_with_dml branch Apr 13, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 26, 2021
🤖 I have created a release \*beep\* \*boop\*
## [2.14.0]( (2021-04-26)

### Features

* accept DatasetListItem where DatasetReference is accepted ([#597]( ([c8b5581](
* accept job object as argument to `get_job` and `cancel_job` ([#617]( ([f75dcdf](
* add `Client.delete_job_metadata` method to remove job metadata ([#610]( ([0abb566](
* add `max_queue_size` argument to `RowIterator.to_dataframe_iterable` ([#575]( ([f95f415](
* add type hints for public methods ([#613]( ([f8d4aaa](
* DB API cursors are now iterable ([#618]( ([e0b373d](
* retry google.auth TransportError by default ([#624]( ([34ecc3f](
* use pyarrow stream compression, if available ([#593]( ([dde9dc5](

### Bug Fixes

* consistent percents handling in DB API query ([#619]( ([6502a60](
* missing license headers in new test files ([#604]( ([df48cc5](
* unsetting clustering fileds on Table is now possible ([#622]( ([33a871f](

### Documentation

* add sample to run DML query ([#591]( ([ff2ec3a](
* update the description of the return value of `_QueryResults.rows()` ([#594]( ([8f4c0b8](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants