Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retry google.auth TransportError by default #624

merged 1 commit into from Apr 23, 2021


Copy link

@plamut plamut commented Apr 22, 2021

Closes #620.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut requested review from tswast and a team April 22, 2021 13:55
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Apr 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2021
tswast approved these changes Apr 23, 2021
Copy link

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Note: I see that googleapis/python-storage#418 tries to be a bit more specific about which TransportErrors it retries, but I don't actually see a problem with applying our retry logic on any low-level transport errors.

@tswast tswast merged commit 34ecc3f into googleapis:master Apr 23, 2021
10 checks passed
gcf-merge-on-green bot pushed a commit that referenced this pull request Apr 26, 2021
🤖 I have created a release \*beep\* \*boop\*
## [2.14.0]( (2021-04-26)

### Features

* accept DatasetListItem where DatasetReference is accepted ([#597]( ([c8b5581](
* accept job object as argument to `get_job` and `cancel_job` ([#617]( ([f75dcdf](
* add `Client.delete_job_metadata` method to remove job metadata ([#610]( ([0abb566](
* add `max_queue_size` argument to `RowIterator.to_dataframe_iterable` ([#575]( ([f95f415](
* add type hints for public methods ([#613]( ([f8d4aaa](
* DB API cursors are now iterable ([#618]( ([e0b373d](
* retry google.auth TransportError by default ([#624]( ([34ecc3f](
* use pyarrow stream compression, if available ([#593]( ([dde9dc5](

### Bug Fixes

* consistent percents handling in DB API query ([#619]( ([6502a60](
* missing license headers in new test files ([#604]( ([df48cc5](
* unsetting clustering fileds on Table is now possible ([#622]( ([33a871f](

### Documentation

* add sample to run DML query ([#591]( ([ff2ec3a](
* update the description of the return value of `_QueryResults.rows()` ([#594]( ([8f4c0b8](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
None yet

Successfully merging this pull request may close these issues.

google.auth.exceptions.TransportError is not being retried
2 participants