Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update the description of the return value of _QueryResults.rows() #594

merged 1 commit into from Apr 8, 2021


Copy link

@kdeggelman kdeggelman commented Apr 7, 2021

Updated the description of the return value of rows to be more accurate.

@kdeggelman kdeggelman requested a review from as a code owner Apr 7, 2021
@kdeggelman kdeggelman requested review from shollyman and removed request for Apr 7, 2021
Copy link

@google-cla google-cla bot commented Apr 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.


@kdeggelman kdeggelman changed the title Minor doc improvements docs: Updated the description of the return value of rows Apr 7, 2021
@shollyman shollyman requested review from tswast and removed request for shollyman Apr 7, 2021
@plamut plamut changed the title docs: Updated the description of the return value of rows docs: update the description of the return value of _QueryResults.rows() Apr 8, 2021
plamut approved these changes Apr 8, 2021
Copy link

@plamut plamut left a comment

Looks good, thanks for that!


@gcf-merge-on-green gcf-merge-on-green bot merged commit 8f4c0b8 into googleapis:master Apr 8, 2021
9 of 10 checks passed
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 26, 2021
🤖 I have created a release \*beep\* \*boop\*
## [2.14.0]( (2021-04-26)

### Features

* accept DatasetListItem where DatasetReference is accepted ([#597]( ([c8b5581](
* accept job object as argument to `get_job` and `cancel_job` ([#617]( ([f75dcdf](
* add `Client.delete_job_metadata` method to remove job metadata ([#610]( ([0abb566](
* add `max_queue_size` argument to `RowIterator.to_dataframe_iterable` ([#575]( ([f95f415](
* add type hints for public methods ([#613]( ([f8d4aaa](
* DB API cursors are now iterable ([#618]( ([e0b373d](
* retry google.auth TransportError by default ([#624]( ([34ecc3f](
* use pyarrow stream compression, if available ([#593]( ([dde9dc5](

### Bug Fixes

* consistent percents handling in DB API query ([#619]( ([6502a60](
* missing license headers in new test files ([#604]( ([df48cc5](
* unsetting clustering fileds on Table is now possible ([#622]( ([33a871f](

### Documentation

* add sample to run DML query ([#591]( ([ff2ec3a](
* update the description of the return value of `_QueryResults.rows()` ([#594]( ([8f4c0b8](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants