Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

fix: Updated max_results to 100 to avoid too many API calls #108

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

rsamborski
Copy link
Member

@rsamborski rsamborski commented Aug 19, 2021

Based on @amanda-tarafa comment in C# sample (https://github.com/GoogleCloudPlatform/dotnet-docs-samples/pull/1445/files#r687921807) I am changing the max_results value to 100

Checklist:

  • [N/A] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • [N/A] Appropriate docs were updated (if necessary)

🦕

@rsamborski rsamborski added samples Issues that are directly related to samples. api: compute Issues related to the googleapis/python-compute API. labels Aug 19, 2021
@rsamborski rsamborski requested a review from a team as a code owner August 19, 2021 13:58
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2021
@leahecole leahecole changed the title Updated max_results to 100 to avoid too many API calls fix: Updated max_results to 100 to avoid too many API calls Aug 19, 2021
@leahecole
Copy link
Contributor

LGTM! @rsamborski please follow the steps in the "Details" section next to the failing check to amend the commit message and then we should be good to merge! 😄

@rsamborski rsamborski merged commit 691e38e into master Aug 20, 2021
@rsamborski rsamborski deleted the rsamborski-patch-1 branch August 20, 2021 13:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants