Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

fix(deps): allow protobuf < 5.0.0 #320

Merged
merged 4 commits into from Aug 12, 2022
Merged

fix(deps): allow protobuf < 5.0.0 #320

merged 4 commits into from Aug 12, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 11, 2022

fix(deps): require proto-plus >= 1.22.0

@parthea parthea requested review from a team as code owners August 11, 2022 16:55
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: compute Issues related to the googleapis/python-compute API. labels Aug 11, 2022
@unforced unforced added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Aug 11, 2022
@unforced
Copy link

=================================== FAILURES ===================================
______________________ TestComputeSmoke.test_zero_values _______________________

self = <test_smoke.TestComputeSmoke testMethod=test_zero_values>

    def test_zero_values(self):
        with self.assertRaises(expected_exception=TypeError) as ex:
            self.client.get(instance=self.name, zone=0)
>       self.assertIn(
            "0 has type int, but expected one of: bytes, unicode",
            str(ex.exception.args),
        )
E       AssertionError: '0 has type int, but expected one of: bytes, unicode' not found in "('bad argument type for built-in operation',)"

tests/system/test_smoke.py:77: AssertionError
- generated xml file: /tmpfs/src/github/python-compute/system_3.8_sponge_log.xml -
=========================== short test summary info ============================
FAILED tests/system/test_smoke.py::TestComputeSmoke::test_zero_values - Asser...

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 11, 2022
@gcf-merge-on-green
Copy link

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 12, 2022
@leahecole leahecole merged commit e4edea7 into main Aug 12, 2022
@leahecole leahecole deleted the allow-protobuf-4 branch August 12, 2022 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: compute Issues related to the googleapis/python-compute API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants