Skip to content
This repository has been archived by the owner on Oct 16, 2023. It is now read-only.

docs(samples): add deny samples and tests #209

Merged
merged 25 commits into from
Jul 15, 2022
Merged

docs(samples): add deny samples and tests #209

merged 25 commits into from
Jul 15, 2022

Conversation

Sita04
Copy link
Contributor

@Sita04 Sita04 commented Jun 30, 2022

Added samples and tests for IAM deny launch.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: iam Issues related to the googleapis/python-iam API. samples Issues that are directly related to samples. labels Jun 30, 2022
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Jul 1, 2022
@Sita04 Sita04 marked this pull request as ready for review July 5, 2022 05:29
@Sita04 Sita04 requested a review from a team as a code owner July 5, 2022 05:29
@Sita04 Sita04 requested a review from nicain July 5, 2022 05:29
@snippet-bot
Copy link

snippet-bot bot commented Jul 6, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

hegemonic
hegemonic suggested changes Jul 6, 2022
View reviewed changes
Copy link

@hegemonic hegemonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my comments on googleapis/java-iam#371 also apply to this pull request. Can you make those changes here? I'll review more closely after that.

@Sita04 Sita04 added the blunderbuss: assign Instruct blunderbuss to assign someone label Jul 8, 2022
hegemonic
hegemonic suggested changes Jul 8, 2022
View reviewed changes
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/noxfile.py Show resolved Hide resolved
hegemonic
hegemonic suggested changes Jul 13, 2022
View reviewed changes
samples/snippets/deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/noxfile.py Show resolved Hide resolved
@Sita04 Sita04 requested a review from nicain July 14, 2022 17:34
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022
hegemonic
hegemonic suggested changes Jul 14, 2022
View reviewed changes
samples/snippets/create_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/create_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/create_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/create_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/delete_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/create_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/list_deny_policies.py Outdated Show resolved Hide resolved
samples/snippets/update_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/update_deny_policy.py Outdated Show resolved Hide resolved
samples/snippets/update_deny_policy.py Outdated Show resolved Hide resolved
@Sita04 Sita04 merged commit 35cc484 into main Jul 15, 2022
@Sita04 Sita04 deleted the deny-samples branch July 15, 2022 06:19
@release-please release-please bot mentioned this pull request Jul 15, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hegemonic hegemonic hegemonic requested changes

@parthea parthea parthea left review comments

@nicain nicain nicain approved these changes

Assignees
No one assigned
Labels
api: iam Issues related to the googleapis/python-iam API. blunderbuss: assign Instruct blunderbuss to assign someone samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Sita04 @nicain @hegemonic @parthea @yoshi-kokoro