-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples.snippets.subscriber_test: test_receive_with_delivery_attempts failed #291
Comments
Looks like this issue is flaky. 😟 I'm going to leave this open and stop commenting. A human should fix and close this. When run at the same commit (a8c8f53), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge). |
FWIW, I had trouble reproducing this locally, but it happened several times in a row on one of the PRs (link). |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: f890d2d Test outputpublisher_client = topic = 'projects/python-docs-samples-tests/topics/subscription-test-topic-3.6-ebaf1382094248e6bc70ce51214a75c3' dead_letter_topic = 'projects/python-docs-samples-tests/topics/subscription-test-dead-letter-topic-3.6-ebaf1382094248e6bc70ce51214a75c3' subscription_dlq = 'projects/python-docs-samples-tests/subscriptions/subscription-test-subscription-dlq-3.6-ebaf1382094248e6bc70ce51214a75c3' capsys = <_pytest.capture.CaptureFixture object at 0x7fe8ef546710> |
The error message I'll take a look at the test. |
Ah, this is the dlq subscription. I think 404 is thrown when the dlq subscription is not yet ready. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 83c85bd Test outputpublisher_client = topic = 'projects/python-docs-samples-tests/topics/subscription-test-topic-3.7-c278a21861124e49ad4b189cd29bf364' dead_letter_topic = 'projects/python-docs-samples-tests/topics/subscription-test-dead-letter-topic-3.7-c278a21861124e49ad4b189cd29bf364' subscription_dlq = 'projects/python-docs-samples-tests/subscriptions/subscription-test-subscription-dlq-3.7-c278a21861124e49ad4b189cd29bf364' capsys = <_pytest.capture.CaptureFixture object at 0x7f9a3db3ed10> |
My suspicion right now is that the test somehow failed to retry the sample invocation. From the last build log, I don't see any signs where the test retrying NotFound exception. |
For example, the log says:
It seems like somehow the build was testing against the code without my backoff change. I don't know why it happened, but that's my interpretation of the logs. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 34c9b11 Test outputpublisher_client = topic = 'projects/python-docs-samples-tests/topics/subscription-test-topic-3.8-6f1b53aa1e5c4232a6d71bdd459ac06d' dead_letter_topic = 'projects/python-docs-samples-tests/topics/subscription-test-dead-letter-topic-3.8-6f1b53aa1e5c4232a6d71bdd459ac06d' subscription_dlq = 'projects/python-docs-samples-tests/subscriptions/subscription-test-subscription-dlq-3.8-6f1b53aa1e5c4232a6d71bdd459ac06d' capsys = <_pytest.capture.CaptureFixture object at 0x7f154fe3f3d0> |
Again, the log indicates that it tests without retrying code.
I'm trying to figure out why it's happening. |
Probably not related, but I noticed that the builds are installing the library from source:
|
Reported: googleapis/synthtool#988 |
I think I understand what's happening. Our test script rewinds the repo to the latest release: python-pubsub/.kokoro/test-samples.sh Lines 25 to 29 in dfc7e47
The test is running without the We fixed flaky tests for sample, but our periodic builds are running test at the latest release tag. Should we make a release? |
@tmatsuo Yep, a release should close the issue. We can chat tomorrow about whether the "rewinding to last release" is the right thing to do or if periodic should just run samples at head. |
It should be fixed now for For a time being, we may see the same error in |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: d40d027 Test outputpublisher_client = topic = 'projects/python-docs-samples-tests/topics/subscription-test-topic-3.8-3e3197671e994bb9a911396fd2e6203a' dead_letter_topic = 'projects/python-docs-samples-tests/topics/subscription-test-dead-letter-topic-3.8-3e3197671e994bb9a911396fd2e6203a' subscription_dlq = 'projects/python-docs-samples-tests/subscriptions/subscription-test-subscription-dlq-3.8-3e3197671e994bb9a911396fd2e6203a' capsys = <_pytest.capture.CaptureFixture object at 0x7fa5ed464a60> |
We fix the flake at head, but the periodic build uses the code without the fix (it rewinds the git to the latest release). It's expected to fail for now. The flake will go away once we release the next version. We do have periodic builds against head. They seem to be green, closing. |
This test failed!
To configure my behavior, see the Flaky Bot documentation.
If I'm commenting on this issue too often, add the
flakybot: quiet
label andI will stop commenting.
commit: a8c8f53
buildURL: Build Status, Sponge
status: failed
Test output
The text was updated successfully, but these errors were encountered: