Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set min snooze on lease management to .01 sec #678

Merged
merged 2 commits into from
May 4, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented May 4, 2022

Setting the minimum lease snooze to .01 sec (the value of MAX_BATCH_LATENCY), to prevent duplicate modacks from being sent within a batch.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Addresses #675 🦕

@acocuzzo acocuzzo requested review from a team as code owners May 4, 2022 18:04
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels May 4, 2022
@acocuzzo acocuzzo linked an issue May 4, 2022 that may be closed by this pull request
@pradn
Copy link
Contributor

pradn commented May 4, 2022

Thanks Anna! This PR fixes half the problem in #675. The other half is making sure there's some time before the ack deadline expires (allowing for network delay). Aka we need to change the maximum as well to add a buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider calculation of time between leaser runs
2 participants