Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

fix: omit tests package #193

Merged
merged 2 commits into from
Apr 28, 2022
Merged

fix: omit tests package #193

merged 2 commits into from
Apr 28, 2022

Conversation

s22chan
Copy link
Contributor

@s22chan s22chan commented Apr 28, 2022

caused by 8fa2ec4

Apoligies if I'm missing something: I'm not entirely sure why the local packages/namespaces are still being generated but then discarded for the actual setuptools.setup.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #194 🦕

caused by 8fa2ec4

Apoligies if I'm missing something: I'm not entirely sure why the local packages/namespaces are still being generated but then discarded for the actual `setuptools.setup`.
@s22chan s22chan requested a review from a team as a code owner April 28, 2022 03:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: cloudresourcemanager Issues related to the googleapis/python-resource-manager API. labels Apr 28, 2022
@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 28, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2022
@parthea
Copy link
Contributor

parthea commented Apr 28, 2022

Thanks for reporting and fixing this issue @s22chan !

@parthea parthea merged commit be8ecab into googleapis:main Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: cloudresourcemanager Issues related to the googleapis/python-resource-manager API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests are being packaged
2 participants