Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add databoost enabled property for batch transactions #892

Merged
merged 18 commits into from
Apr 6, 2023
Merged

feat: add databoost enabled property for batch transactions #892

merged 18 commits into from
Apr 6, 2023

Conversation

asthamohta
Copy link
Contributor

No description provided.

@asthamohta asthamohta requested review from a team as code owners February 3, 2023 04:15
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 3, 2023
@snippet-bot
Copy link

snippet-bot bot commented Feb 3, 2023 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Feb 3, 2023
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Feb 8, 2023
@asthamohta asthamohta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 2, 2023
gauravpurohit06
gauravpurohit06 approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@gauravpurohit06 gauravpurohit06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rajatbhatta
rajatbhatta approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@rajatbhatta rajatbhatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a few nit suggestions.

google/cloud/spanner_v1/database.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/snapshot.py Outdated Show resolved Hide resolved
asthamohta and others added 2 commits April 6, 2023 16:10
@asthamohta @rajatbhatta
Update google/cloud/spanner_v1/snapshot.py
ec7d66e 
Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
@asthamohta @rajatbhatta
Update google/cloud/spanner_v1/database.py
3db4f69 
Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
@asthamohta asthamohta enabled auto-merge (squash) April 6, 2023 10:40
@asthamohta asthamohta merged commit ffb3915 into googleapis:main Apr 6, 2023
@release-please release-please bot mentioned this pull request Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravpurohit06 gauravpurohit06 gauravpurohit06 approved these changes

@rajatbhatta rajatbhatta rajatbhatta approved these changes

@loferris loferris Awaiting requested review from loferris loferris is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asthamohta @gauravpurohit06 @rajatbhatta @yoshi-kokoro