Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] V4 Signature Support for virtual hosted-style signed #10

Closed
frankyn opened this issue Jan 23, 2020 · 2 comments · Fixed by #58 or #83
Closed

[Storage] V4 Signature Support for virtual hosted-style signed #10

frankyn opened this issue Jan 23, 2020 · 2 comments · Fixed by #58 or #83
Assignees
@tseaver @HemangChothani
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@frankyn
Copy link
Member

frankyn commented Jan 23, 2020

Tracking issue for work defined in companion document.

New Client Request - Support for virtual hosted-style signed URLs
@crwilcox crwilcox transferred this issue from googleapis/google-cloud-python Jan 31, 2020
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jan 31, 2020
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Feb 3, 2020
@jkwlui jkwlui added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Feb 4, 2020
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Feb 4, 2020
@HemangChothani HemangChothani self-assigned this Feb 10, 2020
@tseaver
Copy link
Contributor

tseaver commented Feb 13, 2020 •
edited
Loading

Analysis:

  • _signing.generate_signed_url_v4 already supports this feature via its api_access_endpoint argument.
  • We could add a use_virtual_host flag to Blob.generate_signed_url and Bucket.generate_signed_url which defaults False for now (following Option 2 in the spec). If set to True, then the blob/bucket would pass in the appropriate api_access_endpoint, along with the shorter resource.

@tseaver tseaver mentioned this issue Feb 13, 2020
Merged
@frankyn frankyn reopened this Mar 11, 2020
@frankyn
Copy link
Member Author

frankyn commented Mar 11, 2020

Missing conformance tests

@HemangChothani HemangChothani mentioned this issue Mar 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

@HemangChothani HemangChothani

Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
5 participants
@tseaver @frankyn @jkwlui @yoshi-automation @HemangChothani