Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Blob.from_string parse gcs uri with regex #1170

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: Blob.from_string parse gcs uri with regex #1170

merged 2 commits into from
Oct 31, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Oct 20, 2023

Fixes #1107 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Oct 20, 2023
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 23, 2023
@cojenco cojenco marked this pull request as ready for review October 23, 2023 22:29
@cojenco cojenco requested review from a team as code owners October 23, 2023 22:29
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 31, 2023
@cojenco cojenco merged commit 0a243fa into googleapis:main Oct 31, 2023
13 checks passed
@release-please release-please bot mentioned this pull request Oct 31, 2023
Merged
@Ark-kun
Copy link

Ark-kun commented Jan 12, 2024

This change should likely be highlighted as a breaking change in the storage library since the new code starts raising errors for strings that worked before.

@cojenco cojenco deleted the from_string branch October 30, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blob.from_string() should be able to parse all valid gcs uri
3 participants
@cojenco @Ark-kun @andrewsg