Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add AbortIncompleteMultipartUpload lifecycle rule #765

Merged
merged 6 commits into from
Apr 15, 2022
Merged

feat: add AbortIncompleteMultipartUpload lifecycle rule #765

merged 6 commits into from
Apr 15, 2022

Conversation

andrewsg
Copy link
Contributor

Fixes #753 🦕

@andrewsg andrewsg requested review from a team as code owners April 13, 2022 16:40
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Apr 13, 2022
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2022
cojenco
cojenco reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for working on this! I'll be adding the prefix/suffix support on top of this :)

cojenco
cojenco reviewed Apr 15, 2022
View reviewed changes
tests/system/test_bucket.py Outdated
bucket.lifecycle_rules = rules
bucket.patch()

bucket.reload()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious do we need to reload the bucket here, same on L111? The patch call should return the bucket metadata? Otherwise, LGTM, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, you're right, we should be able to skip that. I'll remove them and confirm it still works.

@andrewsg andrewsg added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 15, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit b2e5150 into main Apr 15, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the lifecycle branch April 15, 2022 17:42
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 15, 2022
@release-please release-please bot mentioned this pull request Apr 15, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@BrennaEpp BrennaEpp Awaiting requested review from BrennaEpp

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AbortIncompleteMultipartUpload LifecycleAction
3 participants
@andrewsg @cojenco @yoshi-kokoro