Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: clarify prefixes entity in list_blobs and link sample #837

Merged
merged 2 commits into from
Aug 11, 2022
Merged

docs: clarify prefixes entity in list_blobs and link sample #837

merged 2 commits into from
Aug 11, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Aug 9, 2022

Improve documentation as part of 294

Fixes #294 🦕

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. labels Aug 9, 2022
@cojenco cojenco marked this pull request as ready for review August 9, 2022 22:25
@cojenco cojenco requested review from a team as code owners August 9, 2022 22:25
dandhlee
dandhlee approved these changes Aug 10, 2022
View reviewed changes
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One minor comment

google/cloud/storage/client.py Show resolved Hide resolved
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7101f47 into googleapis:main Aug 11, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 11, 2022
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
@cojenco cojenco deleted the 294-list branch February 1, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

There should be a built-in way to list prefixes (directories) in a bucket
2 participants
@cojenco @dandhlee