Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add predefined_acl to create_resumable_upload_session #878

Merged
merged 2 commits into from
Oct 4, 2022
Merged

feat: add predefined_acl to create_resumable_upload_session #878

merged 2 commits into from
Oct 4, 2022

Conversation

ddelange
Copy link
Contributor

@ddelange ddelange commented Sep 28, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #877 🦕

@ddelange ddelange requested review from a team as code owners September 28, 2022 10:46
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Sep 28, 2022
@ddelange ddelange mentioned this pull request Sep 28, 2022
Closed
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 28, 2022
@ddelange ddelange force-pushed the patch-1 branch 2 times, most recently from f2061fe to af06da0 Compare September 28, 2022 14:04
@ddelange ddelange mentioned this pull request Sep 28, 2022
Closed
5 tasks
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 28, 2022
@ddelange
Copy link
Contributor Author

Hi @cojenco 👋

Could you re-run failed CI?

I copied over the qs_params addition from _do_multipart_success test helper, that should do the trick.

@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@cojenco cojenco changed the title Add predefined_acl to create_resumable_upload_session feat: add predefined_acl to create_resumable_upload_session Sep 29, 2022
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 29, 2022
cojenco
cojenco approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@cojenco cojenco merged commit 2b3e8f9 into googleapis:main Oct 4, 2022
@release-please release-please bot mentioned this pull request Oct 4, 2022
Merged
@ddelange ddelange mentioned this pull request Jul 29, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support predefined_acl in create_resumable_upload_session
4 participants
@ddelange @cojenco @yoshi-kokoro @ddelgrosso1