Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Failing tests on master, worried flakybot is not configured #35

Closed
JustinBeckwith opened this issue Feb 14, 2021 · 3 comments
Closed

Failing tests on master, worried flakybot is not configured #35

JustinBeckwith opened this issue Feb 14, 2021 · 3 comments
Assignees
Labels
api: websecurityscanner Issues related to the googleapis/python-websecurityscanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@JustinBeckwith
Copy link
Contributor

Looking at #34, it looks like tests are failing on master. That in and of itself is a problem, but I'm far more concerned that flakybot isn't configured properly or doing it's thing.

@product-auto-label product-auto-label bot added the api: websecurityscanner Issues related to the googleapis/python-websecurityscanner API. label Feb 14, 2021
@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Feb 14, 2021
@busunkim96
Copy link
Contributor

Yep you're correct, flakybot is only configured on the samples tests so it won't catch anything that breaks elsewhere.

@JustinBeckwith
Copy link
Contributor Author

Interesting! Which specific tests are breaking here? System? Unit? Is it common for those to be persistently broken without the samples tests being broken?

The spirit of what I'm trying to get at here - if master is red, and we're blocked - I would like an automatic tracking issue to be filed so we know about it. We're chasing way too many repos to deal with whack-a-repo when they go red.

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 21, 2021
@busunkim96
Copy link
Contributor

This was addressed in googleapis/synthtool#950 and the change will eventually trickle through here in a template PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: websecurityscanner Issues related to the googleapis/python-websecurityscanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

3 participants