Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Please Bot should trigger CI #104

Closed
JustinBeckwith opened this issue Oct 1, 2019 · 4 comments
Closed

Release Please Bot should trigger CI #104

JustinBeckwith opened this issue Oct 1, 2019 · 4 comments
Assignees
Labels
bot: release please type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JustinBeckwith
Copy link
Contributor

I was looking at this PR created by the release-please bot:
googleapis/sloth#328

And noticed that it didn't trigger a kokoro run. I'm not sure what Kokoro uses to decide if jobs should be run, but we should find a way to have PRs created by our bots automagically trigger CI if applicable.

@chingor13
Copy link
Contributor

I think a trusted-tester bot could work for this. The repository would maintain a .github/trusted-tester.yml with a list of approved users.

On pull_request.opened or pull_request.synchronized the bot would add the kokoro:force-run label to the PR.

@crwilcox

@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 1, 2019
@JustinBeckwith
Copy link
Contributor Author

The problem with that approach is that we would need to re-trigger CI every time there is an update to master. Renovate does a good job of auto-updating it's own PRs (which we should consider regardless).

@bcoe
Copy link
Contributor

bcoe commented Oct 7, 2019

this is becoming a bit of a hassle, specifically for release-please bot, it would be nice to look into whether we can at least get that bot whitelisted, such that tests kick off whenever it opens a PR.

@JustinBeckwith
Copy link
Contributor Author

Happy to say this is working swell now ;)

@JustinBeckwith JustinBeckwith self-assigned this Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: release please type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants