Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have rule for verifying commit includes tests for new code #108

Closed
gguuss opened this issue Oct 7, 2019 · 1 comment
Closed

Have rule for verifying commit includes tests for new code #108

gguuss opened this issue Oct 7, 2019 · 1 comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gguuss
Copy link

gguuss commented Oct 7, 2019

We've had a number of commits into the python-docs-samples repo recently from contributors who are not including tests. It'd be great if we had a bot that enforced coverage / tests for new code.

One approach could be to also use the nox --missingtests functionality.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Oct 8, 2019
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 10, 2019
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Oct 10, 2019
@tmatsuo
Copy link
Contributor

tmatsuo commented May 7, 2021

My 2 cents.

This is reasonably hard to implement this feature for various languages.
Also there are coverage tools which has github integrations for most of the languages.

I think it's better to use such tools. Closing, but feel free to reopen.

@tmatsuo tmatsuo closed this as completed May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants