feat(flakybot): notify users when no logs are found #4679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
requested changes
Nov 16, 2022
packages/flakybot/flakybot.go
Outdated
| } | ||
| if len(logs) == 0 { | ||
| log.Printf("No sponge_log.xml files found in %s. Did you forget to generate sponge_log.xml?", cfg.logsDir) | ||
| os.Exit(0) |
There was a problem hiding this comment.
Do we want this to return a successful exit code?
There was a problem hiding this comment.
I debated and am open to changing it. It might not be an error if there is no sponge_log.xml file? But, on the other hand, why would you call flakybot if you didn't have logs?
There was a problem hiding this comment.
I think we want to have the binary throw a failing return exit code otherwise maintainers won't notice
tbpg
commented
Nov 21, 2022
packages/flakybot/flakybot.go
Outdated
| } | ||
| if len(logs) == 0 { | ||
| log.Printf("No sponge_log.xml files found in %s. Did you forget to generate sponge_log.xml?", cfg.logsDir) | ||
| os.Exit(0) |
chingor13
approved these changes
Nov 21, 2022
| logs, err := findLogs(cfg.logsDir) | ||
| if err != nil { | ||
| log.Printf("Error searching for logs: %v", err) | ||
| os.Exit(1) |
There was a problem hiding this comment.
non-blocking: consider using different non-zero exit codes for different error scenarios
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.