Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate proto-only libraries #2047

Closed
JoeWang1127 opened this issue Sep 27, 2023 · 2 comments · Fixed by #2046
Closed

Generate proto-only libraries #2047

JoeWang1127 opened this issue Sep 27, 2023 · 2 comments · Fixed by #2046
Assignees
Labels
hermetic-build priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@JoeWang1127
Copy link
Collaborator

The generate_library.sh should be able to generate libraries which don't have a java_gapic_library bazel target.

@JoeWang1127 JoeWang1127 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. hermetic-build labels Sep 27, 2023
@JoeWang1127 JoeWang1127 self-assigned this Sep 27, 2023
@blakeli0
Copy link
Collaborator

I would call them proto-only libraries, as they are still generated through the whole GAPIC toolchain. In addition, alloydb-connector does not have a gRPC folder as well, so we should not try to run gRPC plugin as well.
Also some other libraries like java-iam have proto and gRPC folder, but no gapic client folder. We should take those scenarios into consideration as well.

@JoeWang1127 JoeWang1127 changed the title Generate non-GAPIC libraries Generate proto-only libraries Sep 27, 2023
@JoeWang1127
Copy link
Collaborator Author

I would call them proto-only libraries, as they are still generated through the whole GAPIC toolchain.

Thanks for pointing it out, I've changed the title.

In addition, alloydb-connector does not have a gRPC folder as well, so we should not try to run gRPC plugin as well.

I noticed that even if I run the grpc plugin with the protos, there's no java file generated. I can simply delete the grpc-* folder if this folder is empty.

Also some other libraries like java-iam have proto and gRPC folder, but no gapic client folder. We should take those scenarios into consideration as well.

java-iam has another issue, I need to exclude google/iam/v1/logging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hermetic-build priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants