Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autosynth should label PRs appropriately #138

Closed
tseaver opened this issue Nov 20, 2018 · 4 comments
Closed

Autosynth should label PRs appropriately #138

tseaver opened this issue Nov 20, 2018 · 4 comments
Assignees
@busunkim96
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 20, 2018

At a minimum, it should apply the correct api: * label to the PR. Even better would be to add the label which indicates the issue is autogen (in google-cloud-python, we use codegen).
@JustinBeckwith JustinBeckwith transferred this issue from googleapis/github-repo-automation Nov 20, 2018
@theacodes theacodes added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 20, 2018
@danoscarmike
Copy link
Contributor

Could we extend this to issues as well as PRs? Particularly I'm interested to have the api: {apiname} label applied to 'Synthesis failed for {apiname}' issues.

@theacodes
Copy link
Contributor

@danoscarmike yeah that should be trivial once the labeling of the PR is in place.

@busunkim96
Copy link
Contributor

Autosynth now adds api: * labels to any PRs and issues it opens. (It will only do this on the mono-repos.)

I will open a separate issue for any other labels (like codegen) different languages would like to have applied to Autosynth PRs.

@busunkim96 busunkim96 mentioned this issue Mar 28, 2019
Closed
@SurferJeffAtGoogle
Copy link
Contributor

The API name is now included in the pull request title for monorepos. Example PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@busunkim96 busunkim96

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tseaver @theacodes @danoscarmike @busunkim96 @SurferJeffAtGoogle