Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

javascript urls aren't sanitized #39

Closed
kpreid opened this issue Apr 16, 2015 · 5 comments
Closed

javascript urls aren't sanitized #39

kpreid opened this issue Apr 16, 2015 · 5 comments

Comments

@kpreid
Copy link
Contributor

kpreid commented Apr 16, 2015

Original issue 39 created by metaweta on 2008-01-18T00:42:08.000Z:

<div id="1"></div>
<script type="text/javascript">
document.getElementById("1").innerHTML="<a
href='javascript:alert(1)'>blah</a>";
</script>

@kpreid
Copy link
Contributor Author

kpreid commented Apr 16, 2015

Comment #1 originally posted by metaweta on 2008-01-18T00:45:35.000Z:

Also, the easier
blah
does get translated to
blah
but still ought to be sanitized

@kpreid
Copy link
Contributor Author

kpreid commented Apr 16, 2015

Comment #2 originally posted by mikesamuel on 2008-01-18T05:08:11.000Z:

Yep. We need to settle on a URI rewriting policy.

GxpCompiler requires all URIs to be relative and not to have .. that escapes to a
parent directory.

Ryan's HtmlCompiler applies no such policy, but we can probably use the UriCallback
policy.

@kpreid
Copy link
Contributor Author

kpreid commented Apr 16, 2015

Comment #3 originally posted by erights on 2008-01-28T20:01:29.000Z:

<empty>

@kpreid
Copy link
Contributor Author

kpreid commented Apr 16, 2015

Comment #4 originally posted by erights on 2008-01-28T20:25:16.000Z:

<empty>

@kpreid
Copy link
Contributor Author

kpreid commented Apr 16, 2015

Comment #5 originally posted by mikesamuel on 2008-03-09T02:51:29.000Z:

This code gets passed through the url callback properly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant