Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(fonts): fix infinite loop #4488

Merged
merged 2 commits into from
Feb 9, 2018
Merged

core(fonts): fix infinite loop #4488

merged 2 commits into from
Feb 9, 2018

Conversation

patrickhulce
Copy link
Collaborator

partial fix to address #4486 and prevent an infinite loop when getting an exception

@wardpeet
Copy link
Collaborator

wardpeet commented Feb 9, 2018

not sure that's the cause of infinite loop but LGTM :)

@paulirish paulirish merged commit 9825c6c into master Feb 9, 2018
@paulirish paulirish deleted the fix_fonts_infinite_loop branch February 9, 2018 15:12
@patrickhulce
Copy link
Collaborator Author

patrickhulce commented Feb 9, 2018

not sure that's the cause of infinite loop but LGTM :)

it certainly was in my case :)

getFontFaceFromStylesheets calls loadStylesheetWithCORS on all errors, loadStylesheetWithCORS calls getFontFaceFromStylesheets and so the cycle repeats infinitely if the error isn't solved by CORS fetching

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants