Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use nyc for coverage, dropping deprecated istanbul #4919

Merged
merged 8 commits into from
Apr 5, 2018
Merged

tests: use nyc for coverage, dropping deprecated istanbul #4919

merged 8 commits into from
Apr 5, 2018

Conversation

paulirish
Copy link
Member

Istanbul has been choking on async/await since that landed in master.
This fixes that.

brendankenny
brendankenny previously approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely

patrickhulce
patrickhulce previously approved these changes Apr 4, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏙

@brendankenny brendankenny dismissed their stale review April 4, 2018 05:48

I'll need to look again :P

@paulirish
Copy link
Member Author

paulirish commented Apr 4, 2018 •
edited
Loading

yah! np. :)

Okay it looks like coverage went down half a percent. Why?

https://codecov.io/gh/GoogleChrome/lighthouse/pull/4919/changes

The updated instrumentation handles the first line of a function differently. Should report LESS now. (before on left, after on right)
image

Lots of istanbul ignore next were being ignored. And they are now being respected. Dont know how we had coverage in these clientside fn's but OK.
image
This affects a bunch of other files.

@paulirish
Copy link
Member Author

to confirm, this is ready for a new review. I've looked over the coverage data and am happy with where things stand.

patrickhulce
patrickhulce reviewed Apr 4, 2018
View reviewed changes
package.json
"core-unit": "yarn unit-core",
"cli-unit": "yarn unit-cli",
"viewer-unit": "yarn unit-viewer",
"watch": "yarn unit-core --watch",

"unit:silentcoverage": "nyc --silent yarn unit",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why silent coverage? just got annoyed with it in output?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah here's an example: https://travis-ci.org/GoogleChrome/lighthouse/builds/361959444?utm_source=github_status&utm_medium=notification

lighthouse-core/scripts/run-mocha.sh
@@ -1,27 +0,0 @@
#!/usr/bin/env bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

package.json
"unit-viewer": "bash lighthouse-core/scripts/run-mocha.sh --viewer",
"unit": "bash lighthouse-core/scripts/run-mocha.sh --default",

"unit-core": "mocha --reporter dot \"lighthouse-core/test/**/*-test.js\"",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we just use single quotes instead? escaping hurts my 👀

brendankenny
brendankenny approved these changes Apr 4, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fantastic

@paulirish
Revert "single quote."
155bfb2 
This reverts commit fa30b00.
@paulirish paulirish merged commit 3e55085 into master Apr 5, 2018
@paulirish paulirish deleted the istanbul2nyc branch April 27, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulirish @brendankenny @patrickhulce @devtools-bot