Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(network-recorder): fix typo in once() call on super #4926

Merged
merged 1 commit into from
Apr 5, 2018
Merged

core(network-recorder): fix typo in once() call on super #4926

merged 1 commit into from
Apr 5, 2018

Conversation

brendankenny
Copy link
Member

Introduced in #4918, networkRecorder.once() calls are being rerouted to networkRecorder.on(), which isn't great :)

patrickhulce
patrickhulce reviewed Apr 4, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reasonable test we could do for this? or does it not really have an effect on us other than the leak message :)

@brendankenny
Copy link
Member Author

I think yeah, just leaking. The listeners just listen forever, equivalent if the original call sites had accidentally called on.

@brendankenny
Copy link
Member Author

@patrickhulce: @paulirish said you touched this last so you have to approve :P

@patrickhulce patrickhulce merged commit 2a24423 into master Apr 5, 2018
@patrickhulce patrickhulce deleted the once branch April 5, 2018 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendankenny @patrickhulce @paulirish @devtools-bot