Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric Rating Thresholds not included in attribution builds #338

Closed
yuhui opened this issue Mar 31, 2023 · 1 comment · Fixed by #340
Closed

Metric Rating Thresholds not included in attribution builds #338

yuhui opened this issue Mar 31, 2023 · 1 comment · Fixed by #340

Comments

@yuhui
Copy link

yuhui commented Mar 31, 2023

Actual result: In the attribution builds, none of the Metric Rating Thresholds are included. Tested with web-vitals.attribution.js, web-vitals.attribution.umd.cjs and web-vitals.attribution.iife.js.

Expected result: With the attribution builds, Metric Rating Thresholds should be available as described at https://github.com/GoogleChrome/web-vitals#rating-thresholds

Affected version: 3.3.0

@tunetheweb
Copy link
Member

Looks like we missed adding them to:
https://github.com/GoogleChrome/web-vitals/blob/main/src/attribution.ts

Will add and prepare a new release but might take a day or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants