Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sessionId instead of targetId to associate CDP client with a Context #60

Open
bwalderman opened this issue Oct 18, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@bwalderman
Copy link
Collaborator

The _handleDetachedFromTargetEvent function in browsingContextProcessor.ts uses the targetId parameter on the detachedFromTarget event which is depreacted. The sessionId parameter is recommended instead. This is likely because CDP supports multiple CDP sessions attached to the same Target (although we only use 1 CDP session for our purposes).

This tracks updating our code to use the sessionId parameter here instead. We would likely need to maintain a map in the browsingContextProcessor mapping CDP session IDs to Context objects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants