Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename: browser -> release; vendor -> browser #58

Closed
mdittmer opened this issue May 5, 2017 · 2 comments
Closed

Rename: browser -> release; vendor -> browser #58

mdittmer opened this issue May 5, 2017 · 2 comments
Assignees
@mdittmer

Comments

@mdittmer
Copy link
Collaborator

mdittmer commented May 5, 2017

Based on discussion of #57 we should rename classes and variables named browser* (except browserName and browserVersion) to release*, because we intend a particular release of a browser. Similarly, comments and variable names that refer to vendor actually refer to a particular browser (which has multiple releases).

@arobins does that sound right?
@mdittmer mdittmer self-assigned this May 5, 2017
@arobins
Copy link
Contributor

arobins commented May 5, 2017

sgtm

This was referenced May 8, 2017
Merged
Merged
@mdittmer
Copy link
Collaborator Author

Fixed in 4f4d92b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdittmer mdittmer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdittmer @arobins