-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prioritize maskable icons for apple-touch-icon #33
Comments
We could probably prefer the maskable icons for generating the I don't see a huge disadvantage in continuing to check for and add a solid background. The spec says that maskable icons should not be transparent but can't enforce that in any way. |
I agree that its probably fine to keep adding a solid background. It should be simple to process the maskable icons in the exact same way as a standard icon that's a square with no transparent background. I'm happy to send a PR if you like! |
Sure, if you like! 👍
…On Mon., 19 Aug. 2019, 19:26 Tiger Oakes, ***@***.***> wrote:
I agree that its probably fine to keep adding a solid background. It
should be simple to process the maskable icons in the exact same way as a
standard icon that's a square with no transparent background. I'm happy to
send a PR if you like!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#33?email_source=notifications&email_token=AAA5DEG737NBJNQ2R2KKAX3QFNI6TA5CNFSM4IMN7XF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4U3D2Q#issuecomment-522826218>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAA5DEDUO3FNBJM7UG3LO5DQFNI6TANCNFSM4IMN7XFQ>
.
|
If an icon has
"purpose": "maskable"
, that indicates it should not be transparent and is suited to be masked to shapes like iOS' rounded squares.Some potential behaviour options:
The text was updated successfully, but these errors were encountered: