Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prioritize maskable icons for apple-touch-icon #33

Closed
NotWoods opened this issue Aug 17, 2019 · 3 comments · Fixed by #34
Closed

Prioritize maskable icons for apple-touch-icon #33

NotWoods opened this issue Aug 17, 2019 · 3 comments · Fixed by #34

Comments

@NotWoods
Copy link
Contributor

If an icon has "purpose": "maskable", that indicates it should not be transparent and is suited to be masked to shapes like iOS' rounded squares.

Some potential behaviour options:

  • Include the maskable icons with no priority (current behaviour)
  • If a maskable icon is present, discard the non-maskable icons and only use maskable icons for apple-touch-icon
  • Rank maskable icons higher somehow (does Safari use the first icon it encounters?)
@NotWoods NotWoods changed the title Prioritize maskable icons Prioritize maskable icons for apple-touch-icon Aug 17, 2019
@samthor
Copy link
Contributor

samthor commented Aug 19, 2019

We could probably prefer the maskable icons for generating the apple-touch-icon or splash screen, especially if they have the same pixel size as a non-maskable icon. WDYT?

I don't see a huge disadvantage in continuing to check for and add a solid background. The spec says that maskable icons should not be transparent but can't enforce that in any way.

@NotWoods
Copy link
Contributor Author

I agree that its probably fine to keep adding a solid background. It should be simple to process the maskable icons in the exact same way as a standard icon that's a square with no transparent background. I'm happy to send a PR if you like!

@samthor
Copy link
Contributor

samthor commented Aug 20, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants