Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate is cloudevent dependency is still needed #73

Closed
steren opened this issue Jul 22, 2023 · 1 comment
Closed

Evaluate is cloudevent dependency is still needed #73

steren opened this issue Jul 22, 2023 · 1 comment

Comments

@steren
Copy link
Collaborator

steren commented Jul 22, 2023

This sample depends on github.com/cloudevents/sdk-go/v2 and has a lot of logic to parse CloudEvent.

This is source of potential vulnerability and code complexity.

It's unclear that this sample still needs to be able to handle CloudEvent.

We should figure out if it is used in any EventArc sample or if it used to demo EventArc.

If not, we should remove this dependency and code.

@steren
Copy link
Collaborator Author

steren commented Jul 22, 2023

@steren steren closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant