Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take ValueFormat into account when compiling ValueRecord #189

Closed
cmyr opened this issue Dec 20, 2022 · 0 comments · Fixed by #289
Closed

Take ValueFormat into account when compiling ValueRecord #189

cmyr opened this issue Dec 20, 2022 · 0 comments · Fixed by #289
Labels
bug Something isn't working

Comments

@cmyr
Copy link
Member

cmyr commented Dec 20, 2022

currently, when compiling value records, we skip null values. This means it is currently impossible for us to correctly compile a value record which contains a null device offset, even if this is expected, and the ValueFormat indicates such a table will be present.

If this occurs, we will silently produce an incorrect font.

This is not a very likely scenario, but it is still something we need to address.

The solution to this will likely be some slightly fancier way of indicating custom compilation behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant