Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add/update test files with kerning data #331

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Add/update test files with kerning data #331

merged 3 commits into from
Jun 8, 2023

Conversation

rsheeter
Copy link
Contributor

@rsheeter rsheeter commented Jun 6, 2023 •
edited

Files used in #331; split out here in hopes of making review simpler.

Step toward #308

@rsheeter rsheeter changed the title [WIP] Find the kerning groups from a .glyphs file [WIP] Load kerning groups from .glyphs files Jun 6, 2023
Base automatically changed from kern to main June 6, 2023 20:25
@rsheeter rsheeter changed the title [WIP] Load kerning groups from .glyphs files [WIP] Load kerning from .glyphs files into an explicit IR model of kerning Jun 6, 2023
@rsheeter rsheeter force-pushed the kern2 branch 2 times, most recently from 5121112 to 464f7f6 Compare June 7, 2023 23:58
@rsheeter rsheeter changed the title [WIP] Load kerning from .glyphs files into an explicit IR model of kerning Add/update test files with kerning data Jun 8, 2023
@rsheeter rsheeter marked this pull request as ready for review June 8, 2023 00:07
cmyr
cmyr approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, two little notes inline but nothing blocking :)

glyphs-reader/src/font.rs Outdated Show resolved Hide resolved
glyphs-reader/src/font.rs Show resolved Hide resolved
@rsheeter rsheeter merged commit 0446596 into main Jun 8, 2023
6 checks passed
@rsheeter rsheeter deleted the kern2 branch June 8, 2023 16:37
@anthrotype anthrotype mentioned this pull request Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Compile Oswald and compare to fontmake
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsheeter @cmyr @anthrotype