Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Overhaul CrOS post-processing #186

Closed
wants to merge 1 commit into from
Closed

Conversation

jungshik
Copy link
Contributor

@jungshik jungshik commented Jun 2, 2016

  • Add touchup_for_cros.py
    • Update version (name table) and revision (OS/2)
    • Drop name table records other than for {pid=3,eid=1,langId=0x409}
  • touch_up_web.py
    • apply_web_specific_fixes is split into 2 parts:
      apply_web_cros_common_fixes() and
      apply_web_specific_fixes()
    • Update version (name table) and revision (OS/2)
  • temporary_touchups.py
    • Add an optional 'is_for_cros' to apply_tempoary_fixes.
      When is_for_cros is True, usWeightClass is set to 100 for Thin.
      Tthe latest release version of fontconfig on CrOS does not
      distinguish between Thin and Light when it's 250 for Thin.
  • Makefile
    • Fix chromeos target

This will fix #179 for CrOS build and #182.

* Add touchup_for_cros.py
  - Update version (name table) and revision (OS/2)
  - Drop name table records other than for {pid=3,eid=1,langId=0x409}

* touch_up_web.py
  - apply_web_specific_fixes is split into 2 parts:
    apply_web_cros_common_fixes() and
    apply_web_specific_fixes()
  - Update version (name table) and revision (OS/2)

* temporary_touchups.py
  - Add an optional 'is_for_cros' to apply_tempoary_fixes.
    When is_for_cros is True, usWeightClass is set to 100 for Thin.
    Tthe latest release version of fontconfig on CrOS does not
    distinguish between Thin and Light when it's 250 for Thin.

* Makefile
  - Fix chromeos target
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jungshik
Copy link
Contributor Author

jungshik commented Jun 2, 2016

@roozbehp and @jamesgk
Can you take a look? I cannot edit the 'assignee' field.

@jungshik
Copy link
Contributor Author

jungshik commented Jun 2, 2016

Let me make a new pull request. When I pushed my branch to github, 'user.email' was set to my chromium.org email address (I haven't registered that email address)

@jungshik jungshik closed this Jun 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roboto Thin: do we still need to set usWeightClass to 250?
2 participants