Correct family and style data in name table.

[jamesgk]

This uncomments some code which distinguishes between Regular/Bold and other weights when setting the UFOs' styleMapFamilyName attribute, which is used by the FDK to set the output OTFs' family names (this association is documented here: http://unifiedfontobject.org/versions/ufo2/fontinfo.html). It's not clear why this code was commented out in the first place.

Part of #37

[jamesgk]

cc @roozbehp

[behdad]

Looks about right, but I have no idea why this wasn't done before. So, please merge if you know what you are doing, or get @roozbehp's feedback.

[jamesgk]

This should be fixed, finally, but what still seemed odd to me was that the weight class for Thin is set to 250 (when I would have expected 100) in instanceNames.py. The binaries at https://github.com/google/fonts/tree/master/apache/roboto also use 250.

So when you have the font locally and it's used to render text in a browser, font-weight: 100 applied to that text will use Roboto Light instead of Thin. Presumably this is not an issue when you're using Roboto as a web font, and perhaps the local use is an edge case. Still, is there any reason why we'd want the weight class to be 250?

[behdad]

The 250 is a historical artefact. Windows automatically emboldens fonts with declared weight lower than 250, so for fonts designed to be used on Windows, people typically set the weight to 250 for anything lighter than that.

cc @roozbehp @jungshik

[jamesgk]

Alright, so I will leave it alone for now and we can re-open this if needed.

[mikmikmik]

Hey there @jamesgk @behdad @roozbehp @jungshik
I love this font and use it locally on Linux but there's an issue with the Thin weight in inkscape and Font Manager. In inkscape I cannot view the Thin when the Light is activated, it's not even in the menu. It's partly due to a way Inkscape consider it has the "same CSS value" and so already added as Light. The issue is listed here : https://bugs.launchpad.net/inkscape/+bug/1555109 but still a user should have the weight the font is named after, it's a bit misleading if we think we download a font with a weight of 100 which is in reality a 250. In Font Manager I see it in the list but when I select it, it shows as Light. I actually tried before posting this to modify the weight class to 100 in FontForge and it's working well now. I'll have to ship the modified font with the document though. Thanks for you nice work.

[jungshik]

@mikmikmik Thank you for the feedback. I always argued for using fsWeight = 100 for Noto. If necessary, we can have a special Windows binary with fsWeight=250. Android, Linux and Mac do not care. See #179.

[davelab6]

I'll make thin 250 and extra light 275 as per the documented Google fonts requirements.

…

On Mar 6, 2017 4:53 PM, "jungshik" ***@***.***> wrote: @mikmikmik <https://github.com/mikmikmik> Thank you for the feedback. I always argued for using fsWeight = 100 for Noto. If necessary, we can have a special Windows binary with fsWeight=250. Android, Linux and Mac do not care. See #179 <#179>. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#51 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAP9y-uhn4V0WFrU8J-j13OvYZj8Qrz7ks5rjIBKgaJpZM4E-vQR> .

[mikmikmik]

Microsoft actually set Thin to 100 too :
https://www.microsoft.com/typography/otspec/os2.htm#wtc
Mozilla too, based on the CSS norm :
https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight
Inkscape is based on the SVG norm (same as CSS for fonts) so Inkscape users (Windows too) won't be able to use these fonts properly.