Counter and List Priorities: Default to Ascending.

[markmandel]

Is your feature request related to a problem? Please describe.

A small quality of life improvement - it would be really nice for Fleet.Spec.Priorities and GameServerAllocation.Spec.Priorities the default for order as Ascending.

Describe the solution you'd like

If not defined, make the order Ascending.

Describe alternatives you've considered

Leave it alone and let people be explicit with their ordering.

Additional context

We have the following in our CRD:

agones/install/helm/agones/templates/crds/fleet.yaml

Lines 129 to 134 in 1c536c0

	order:
	type: string
	description: Ascending or Descending sort order. Default is "Ascending" so remove smaller total capacity first. "Descending" would remove larger total capacity first.
	enum:
	- Ascending
	- Descending

So at some point, someone figured we should do this 😄

[markmandel]

@igooch - see any issue with this?

[markmandel]

For Fleet the default should be part of the CRD schema (I believe).

For the GameServerAllocation, this would be part of the function:

agones/pkg/apis/allocation/v1/gameserverallocation.go

Lines 566 to 582 in 648b85b

	func (gsa *GameServerAllocation) ApplyDefaults() {
	if gsa.Spec.Scheduling == "" {
	gsa.Spec.Scheduling = apis.Packed
	}
	if len(gsa.Spec.Selectors) == 0 {
	gsa.Spec.Required.ApplyDefaults()
	for i := range gsa.Spec.Preferred {
	gsa.Spec.Preferred[i].ApplyDefaults()
	}
	} else {
	for i := range gsa.Spec.Selectors {
	gsa.Spec.Selectors[i].ApplyDefaults()
	}
	}
	}