Counter and List Priorities: Set Default to Ascending for Fleet and G… #3736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameServerAllocation
|
Build Failed 😱 Build Id: c03f8c6b-8407-4125-8f72-abab9979899f To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
markmandel
reviewed
Apr 1, 2024
| @@ -132,6 +132,7 @@ spec: | |||
| enum: | |||
| - Ascending | |||
| - Descending | |||
| default: Ascending | |||
There was a problem hiding this comment.
Need to run make gen-install please 😄
| @@ -564,6 +565,13 @@ type GameServerMetadata struct { | |||
|
|
|||
| // ApplyDefaults applies the default values to this GameServerAllocation | |||
| func (gsa *GameServerAllocation) ApplyDefaults() { | |||
| if len(gsa.Spec.Priorities) == 0 { | |||
There was a problem hiding this comment.
Please add tests to:
| @@ -564,6 +565,13 @@ type GameServerMetadata struct { | |||
|
|
|||
| // ApplyDefaults applies the default values to this GameServerAllocation | |||
| func (gsa *GameServerAllocation) ApplyDefaults() { | |||
| if len(gsa.Spec.Priorities) == 0 { | |||
| defaultPriority := agonesv1.Priority{ | |||
| Order: "Ascending", | |||
There was a problem hiding this comment.
Rather than a string, use:
agones/pkg/apis/agones/v1/common.go
Line 46 in e696b03
markmandel
reviewed
Apr 1, 2024
| @@ -564,6 +565,13 @@ type GameServerMetadata struct { | |||
|
|
|||
| // ApplyDefaults applies the default values to this GameServerAllocation | |||
| func (gsa *GameServerAllocation) ApplyDefaults() { | |||
| if len(gsa.Spec.Priorities) == 0 { | |||
There was a problem hiding this comment.
This implementation isn't correct unfortunately - #3734 has it correct - need to loop around each one.
There was a problem hiding this comment.
I haven't seen the other PR. Since the correct approach is in the above mentioned PR, I will close this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ameServerAllocation
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #3683
Special notes for your reviewer: