Feat/counter and list defaulting order to ascending #3734

lacroixthomas · 2024-03-27T20:59:12Z

What type of PR is this?
/kind feature

What this PR does / Why we need it:
Defaulting the order from counter and list priorities to Ascending

Which issue(s) this PR fixes:

Closes #3683

Special notes for your reviewer:

agones-bot · 2024-03-27T21:11:47Z

Build Failed 😱

Build Id: 0806152d-ac8a-4746-89bd-e4737a88c6f5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-27T21:57:20Z

Build Failed 😱

Build Id: 2b06ad49-b470-4f58-84dd-dbea7d107321

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-27T22:37:13Z

Build Failed 😱

Build Id: f3066fa5-889a-4520-a611-ec1c9b52071b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-03-27T23:01:10Z

Build Failed 😱

Build Id: 57f9543c-9f2e-4bc3-bdd4-69e3f9957e86

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

…tion

agones-bot · 2024-03-28T21:31:20Z

Build Succeeded 👏

Build Id: e49fa991-aa3c-4ddf-b0ce-58588976bf85

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://66c939e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-66c939e-amd64

…cending

agones-bot · 2024-03-28T23:16:56Z

Build Succeeded 👏

Build Id: 8927e11c-1c21-46de-8f89-946133542dab

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://ba64cf6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-ba64cf6-amd64

…cending

agones-bot · 2024-03-29T09:07:42Z

Build Succeeded 👏

Build Id: 291cc5ae-5216-4b82-9356-5279909ef879

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://0e9c587-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-0e9c587-amd64

…cending

agones-bot · 2024-03-30T13:47:08Z

Build Succeeded 👏

Build Id: e0cbe639-c690-4f61-9dc2-b9d25123ff31

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://93b2b7b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-93b2b7b-amd64

markmandel · 2024-04-01T23:25:18Z

@Kalaiselvi84 @lacroixthomas - just noticed you duplicated each other's work 😄

I added some review to #3736 on some tests , primarily on the unit test that needs expanding.

No strong opinions on my end who wraps this one up 😄

markmandel

Copying review across, and adding a few more things - but otherwise looks good 👍🏻

markmandel · 2024-04-01T23:53:14Z

pkg/apis/allocation/v1/gameserverallocation.go

@@ -583,6 +583,12 @@ func (gsa *GameServerAllocation) ApplyDefaults() {
 		gsa.Spec.Scheduling = apis.Packed
 	}

+	for i := range gsa.Spec.Priorities {


Please add tests to:

agones/pkg/apis/allocation/v1/gameserverallocation_test.go

Line 31 in a1a1cd9

func TestGameServerAllocationApplyDefaults(t *testing.T) {

Can we also please add a comment here:

agones/pkg/apis/agones/v1/common.go

Line 186 in 986ed9b

// "Ascending" would be smaller available capacity is preferred.

That the default is Ascending.

MR updated following your comments @markmandel 🙂

agones-bot · 2024-04-02T13:53:16Z

Build Failed 😱

Build Id: 7d20d9af-dacb-47d7-b936-0869f068daed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2024-04-02T15:50:52Z

Build Succeeded 👏

Build Id: 4d2a9cc7-052d-4778-83ca-4f414e25e888

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://178beb2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-178beb2-amd64

markmandel

Awesome. Thanks!

…cending

agones-bot · 2024-04-03T01:44:24Z

Build Succeeded 👏

Build Id: e4f84174-627c-4eb1-8482-de32d833020b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://9dca36a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/3734/head:pr_3734 && git checkout pr_3734
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.40.0-dev-9dca36a-amd64

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [agones](https://agones.dev) ([source](https://togithub.com/googleforgames/agones)) | minor | `1.39.0` -> `1.40.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>googleforgames/agones (agones)</summary> ### [`v1.40.0`](https://togithub.com/googleforgames/agones/blob/HEAD/CHANGELOG.md#v1400-2024-04-23) [Compare Source](https://togithub.com/googleforgames/agones/compare/v1.39.0...v1.40.0) [Full Changelog](https://togithub.com/googleforgames/agones/compare/v1.39.0...v1.40.0) **Breaking changes:** - Counters and Lists: Remove Bool Returns by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3738 **Implemented enhancements:** - Leader Election in Custom Controller by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3696 - Migrating from generate-groups.sh to kube_codegen.sh by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3722 - Move GKEAutopilotExtendedDurationPods to Alpha in 1.28+ by [@zmerlynn](https://togithub.com/zmerlynn) in [googleforgames/agones#3729 - Move DisableResyncOnSDKServer to Beta by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3732 - Counters & Lists landing page and doc improvements by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3649 - Graduate FleetAllocationOverflow to Stable by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3733 - Adds Counters and Lists to CSharp SDK by [@igooch](https://togithub.com/igooch) in [googleforgames/agones#3581 - Feat/counter and list defaulting order to ascending by [@lacroixthomas](https://togithub.com/lacroixthomas) in [googleforgames/agones#3734 - Add handling for StatusAddresses in GameServerStatus for the Unity SDK by [@charlesvien](https://togithub.com/charlesvien) in [googleforgames/agones#3739 - Feat(gameservers): Shared pod IPs with GameServer Addresses by [@lacroixthomas](https://togithub.com/lacroixthomas) in [googleforgames/agones#3764 - Be prescriptive about rotating regions when updating Kubernetes versions by [@zmerlynn](https://togithub.com/zmerlynn) in [googleforgames/agones#3716 - Fix ensure-e2e-infra-state-bucket by [@zmerlynn](https://togithub.com/zmerlynn) in [googleforgames/agones#3719 - Create Performance Cluster 1.28 by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3720 - Optimise GameServer Sub-Controller Queues by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3781 **Fixed bugs:** - Counters & Lists: Consolidate `priorities` sorting by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3690 - Fix(Counter & Lists): Add validation for `priorities` by [@lacroixthomas](https://togithub.com/lacroixthomas) in [googleforgames/agones#3714 - fix: [#3607](https://togithub.com/googleforgames/agones/issues/3607) Metrics data loss in K8S controller by [@alvin-7](https://togithub.com/alvin-7) in [googleforgames/agones#3692 - Deflake GameServerAllocationDuringMultipleAllocationClients by allowing errors by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3750 **Security fixes:** - Bump protobufjs from 7.2.4 to 7.2.6 in /sdks/nodejs by [@dependabot](https://togithub.com/dependabot) in [googleforgames/agones#3755 - Bump golang.org/x/net from 0.19.0 to 0.23.0 by [@zmerlynn](https://togithub.com/zmerlynn) in [googleforgames/agones#3793 **Other:** - Flaky: TestGameServerCreationAfterDeletingOneExtensionsPod by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3699 - Prep for release v1.40.0 by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3700 - Bumps cpp-simple Image and Refactoring Example Makefiles by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3695 - Upgrade Protobuf to 1.33.0 by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3711 - Modify Script for Makefile Version Updates in Examples Directory by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3712 - Adds simple genai server example documentation to the Agones site by [@igooch](https://togithub.com/igooch) in [googleforgames/agones#3713 - Update Supported Kubernetes to 1.27, 1.28, 1.29 by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3654 - fix: typo in docs by [@qhyun2](https://togithub.com/qhyun2) in [googleforgames/agones#3723 - Tweak: Setting up the Game Server by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3717 - Docs: gke.md - spelling by [@daniellee](https://togithub.com/daniellee) in [googleforgames/agones#3740 - Aesthetic rearrangement of cloudbuild.yaml by [@zmerlynn](https://togithub.com/zmerlynn) in [googleforgames/agones#3741 - Docs: Make hitting <enter> on connection explicit by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3743 - CI: Don't check Unreal Link by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3745 - New recommendation for multi-cluster allocation by [@markmandel](https://togithub.com/markmandel) in [googleforgames/agones#3744 - Custom Controller Example Page on Agones Website by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3725 - Add Nitrado logo by [@towolf](https://togithub.com/towolf) in [googleforgames/agones#3753 - Remove unnecessary args from e2e-test-cloudbuild by [@zmerlynn](https://togithub.com/zmerlynn) in [googleforgames/agones#3754 - Update Allocation from Fleet Documentation by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3761 - Transform Lint Warnings into Errors by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3756 - Update Canary Testing Documentation by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3760 - Supertuxkart Example on Agones Site by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3728 - Xonotic Example on Agones Site by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3742 - nit documentation fix in kind cluster section when building Agones by [@vicentefb](https://togithub.com/vicentefb) in [googleforgames/agones#3770 - Merged steps inside documentation about webhook certificate creation by [@vicentefb](https://togithub.com/vicentefb) in [googleforgames/agones#3768 - Example Images: Increment Tags by [@Kalaiselvi84](https://togithub.com/Kalaiselvi84) in [googleforgames/agones#3796 - Update simple game server example documentation by [@vicentefb](https://togithub.com/vicentefb) in [googleforgames/agones#3776 **New Contributors:** - [@lacroixthomas](https://togithub.com/lacroixthomas) made their first contribution in [googleforgames/agones#3714 - [@daniellee](https://togithub.com/daniellee) made their first contribution in [googleforgames/agones#3740 - [@charlesvien](https://togithub.com/charlesvien) made their first contribution in [googleforgames/agones#3739 - [@vicentefb](https://togithub.com/vicentefb) made their first contribution in [googleforgames/agones#3770 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).

github-actions bot added kind/feature New features for Agones size/XS labels Mar 27, 2024

github-actions bot added the size/M label Mar 27, 2024

lacroixthomas force-pushed the feat/counter-and-list-defaulting-order-to-ascending branch from 999fecb to 6aaa8d0 Compare March 27, 2024 22:45

lacroixthomas added 2 commits March 28, 2024 16:10

feat(counter&list): Defaulting order to ascending in fleet crd

6f68023

feat(counter&list): Defaulting order to ascending in gameserverAlloca…

66c939e

…tion

lacroixthomas force-pushed the feat/counter-and-list-defaulting-order-to-ascending branch from 59ca618 to 66c939e Compare March 28, 2024 20:13

lacroixthomas marked this pull request as ready for review March 28, 2024 20:16

Merge branch 'main' into feat/counter-and-list-defaulting-order-to-as…

ba64cf6

…cending

Merge branch 'main' into feat/counter-and-list-defaulting-order-to-as…

0e9c587

…cending

Merge branch 'main' into feat/counter-and-list-defaulting-order-to-as…

93b2b7b

…cending

markmandel mentioned this pull request Apr 1, 2024

Counter and List Priorities: Set Default to Ascending for Fleet and G… #3736

Closed

markmandel reviewed Apr 1, 2024

View reviewed changes

lacroixthomas added 2 commits April 2, 2024 09:38

feat(counter&list): Update unit test

b07bf97

feat(counter&list): Add default sort order in comment for priority

0a2bd81

github-actions bot added the size/S label Apr 2, 2024

feat(counter&list): Re-run make test-gen-api-docs to update doc

178beb2

github-actions bot added the size/L label Apr 2, 2024

markmandel approved these changes Apr 2, 2024

View reviewed changes

markmandel enabled auto-merge (squash) April 2, 2024 23:56

markmandel and others added 2 commits April 2, 2024 16:56

Merge branch 'main' into feat/counter-and-list-defaulting-order-to-as…

00fb849

…cending

Merge branch 'main' into feat/counter-and-list-defaulting-order-to-as…

9dca36a

…cending

markmandel merged commit efbc412 into googleforgames:main Apr 3, 2024
4 checks passed

lacroixthomas deleted the feat/counter-and-list-defaulting-order-to-ascending branch May 14, 2024 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/counter and list defaulting order to ascending #3734

Feat/counter and list defaulting order to ascending #3734

lacroixthomas commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 29, 2024

agones-bot commented Mar 30, 2024

markmandel commented Apr 1, 2024

markmandel left a comment

markmandel Apr 1, 2024

markmandel Apr 1, 2024

lacroixthomas Apr 2, 2024

agones-bot commented Apr 2, 2024

agones-bot commented Apr 2, 2024

markmandel left a comment

agones-bot commented Apr 3, 2024

Feat/counter and list defaulting order to ascending #3734

Feat/counter and list defaulting order to ascending #3734

Conversation

lacroixthomas commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 27, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 28, 2024

agones-bot commented Mar 29, 2024

agones-bot commented Mar 30, 2024

markmandel commented Apr 1, 2024

markmandel left a comment

Choose a reason for hiding this comment

markmandel Apr 1, 2024

Choose a reason for hiding this comment

markmandel Apr 1, 2024

Choose a reason for hiding this comment

lacroixthomas Apr 2, 2024

Choose a reason for hiding this comment

agones-bot commented Apr 2, 2024

agones-bot commented Apr 2, 2024

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Apr 3, 2024