Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GameServer troubleshooting guide #1003

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Add GameServer troubleshooting guide #1003

merged 1 commit into from
Aug 20, 2019

Conversation

markmandel
Copy link
Member

Including:

  • Using kubectl describe on the GameServer
  • Using kubectl describe on the backing pod
  • Viewing the gameserver logs
  • Pointing to a k8s guide of other kubectl techniques as well.

@markmandel markmandel added kind/feature New features for Agones kind/documentation Documentation for Agones labels Aug 15, 2019
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c527386-c24b-4831-afde-095242cd472d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1003/head:pr_1003 && git checkout pr_1003
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-5c0a1f5

@markmandel
Copy link
Member Author

Preview of the page in question: https://5c0a1f5-dot-preview-dot-agones-images.appspot.com/site/docs/guides/troubleshooting/

roberthbailey
roberthbailey reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the example output shows things that are working, so they don't really illustrate a scenario where a gameserver is unhealthy or a pod is crashing or something. Given that the section is about troubleshooting something that has gone wrong, would it make sense to have some output that actually shows something going wrong?

site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
site/content/en/docs/Guides/troubleshooting.md Outdated Show resolved Hide resolved
@markmandel
Copy link
Member Author

would it make sense to have some output that actually shows something going wrong?

I like it. Done - PTAL!

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b187976d-c7f0-474f-8d72-e5595be8b961

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1003/head:pr_1003 && git checkout pr_1003
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-9d4502a

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0a9948b5-8cd8-422f-9559-30ab47ca9f27

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1003/head:pr_1003 && git checkout pr_1003
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-40ed38f

roberthbailey
roberthbailey reviewed Aug 16, 2019
View reviewed changes
site/content/en/docs/Guides/troubleshooting.md Outdated
2019/08/16 21:26:24 Marking this server as ready
```

Do note that this will only give the most recent container's logs (so we won't get the previous crash). Usually this is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run kubectl logs -p simple-udp-zqppv -c simple-udp it will give you the logs from the prior execution of the container so that you can see the previous crash.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait. You can do what now? runs off to try 😮

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@roberthbailey
Copy link
Member

One last comment that I think is worth fixing before this merges.

@markmandel
Add GameServer troubleshooting guide
7da366e 
Including:
- Using kubectl describe on the GameServer
- Using kubectl describe on the backing pod
- Viewing the gameserver logs
- Pointing to a k8s guide of other kubectl techniques as well.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a519a473-416a-4225-b748-8f4222e22798

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1003/head:pr_1003 && git checkout pr_1003
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-7da366e

@roberthbailey roberthbailey merged commit 7ef4ef6 into googleforgames:master Aug 20, 2019
@markmandel markmandel deleted the docs/troubleshooting branch August 20, 2019 17:57
@markmandel markmandel added this to the 1.0.0 milestone Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees
No one assigned
Labels
kind/documentation Documentation for Agones kind/feature New features for Agones
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markmandel @agones-bot @roberthbailey