Added a pull request template #1471

akremsa · 2020-04-14T14:44:01Z

Closes #608

This template is simple but will be quite helpful.

Do you have any ideas about what kind of information could be added here as well?

Note: labels are not supported yet.

agones-bot · 2020-04-14T14:54:51Z

Build Failed 😱

Build Id: 34ab8d03-5877-4340-be1e-9ce89288c565

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2020-04-14T15:10:06Z

Website test has failed make hugo-test:


make[1]: *** [hugo-test] Error 1
make[1]: Leaving directory '/workspace/build'
includes/website.mk:63: recipe for target 'hugo-test' failed
4 errors in 99 documents
✘✘✘ failed in 4.256748046s
========================================================================
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
  Non-OK status: 404 --- site/docs/advanced/multi-cluster-allocation/index.html --> https://github.com/googleforgames/agones/blob/master/pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go
site/docs/advanced/multi-cluster-allocation/index.html
  Get https://v1-13.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#podtemplatespec-v1-core: x509: certificate is valid for *.netlify.com, netlify.com, not v1-13.docs.kubernetes.io --- site/docs/reference/gameserver/index.html --> https://v1-13.docs.kubernetes.io/docs/reference/generated/kubernetes-api/v1.13/#podtemplatespec-v1-core
site/docs/reference/gameserver/index.html
  Non-OK status: 404 --- site/docs/guides/client-sdks/cpp/index.html --> https://github.com/openssl/openssl/blob/master/INSTALL
site/docs/guides/client-sdks/cpp/index.html
========================================================================
htmltest started at 02:53:17 on /tmp/website

aLekSer · 2020-04-14T15:11:14Z

.github/pull_request_template.md

+**What type of PR is this?**
+> Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line:
+>
+> /kind api-change


We have all of these labels, so this could be a placeholder and in the future we could add commands to set labels. Now reviewer can set labels and this can help to decide which label to use.

Nit: We don't have an api-change label

Other than that, this looks awesome 👍

@thisisnotapril @roberthbailey any other thoughts here?

Removed api-change label

roberthbailey · 2020-04-14T18:28:50Z

/assign @thisisnotapril

agones-bot · 2020-04-16T22:58:59Z

Build Failed 😱

Build Id: 2a74eb8e-322d-421a-a3d8-be0063decec4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-16T23:30:57Z

Build Succeeded 👏

Build Id: 02bffe50-35e7-4e02-a931-f358a69d04f8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-23b9b5a
image: gcr.io/agones-images/agones-sdk:1.6.0-23b9b5a
image: gcr.io/agones-images/agones-ping:1.6.0-23b9b5a
Linux C++ SDK (build): agonessdk-1.6.0-23b9b5a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-23b9b5a.zip

A preview of the website (the last 30 builds are retained):

https://23b9b5a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1471/head:pr_1471 && git checkout pr_1471
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-23b9b5a

roberthbailey · 2020-04-17T05:12:58Z

.github/pull_request_template.md

+*Automatically closes linked issue when PR is merged.
+Usage: `Closes #<issue number>`, or `Closes (paste link of issue)`.
+-->
+Closes #


I personally prefer fixes to closes, but according to https://help.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords both do the same thing.

.github/pull_request_template.md

fix

Removed design label

agones-bot · 2020-04-17T18:54:41Z

Build Failed 😱

Build Id: 166eff3c-3981-421b-a0dd-9ee48a74dae3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-17T19:09:29Z

Build Succeeded 👏

Build Id: cd01b121-769d-430a-b611-c4ecd11febac

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-06d9072
image: gcr.io/agones-images/agones-sdk:1.6.0-06d9072
image: gcr.io/agones-images/agones-ping:1.6.0-06d9072
Linux C++ SDK (build): agonessdk-1.6.0-06d9072-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-06d9072.zip

A preview of the website (the last 30 builds are retained):

https://06d9072-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1471/head:pr_1471 && git checkout pr_1471
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-06d9072

markmandel

Nice!

google-oss-robot · 2020-04-18T05:47:07Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-04-18T05:47:52Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-04-18T06:05:05Z

Build Succeeded 👏

Build Id: d6d6d3c6-34b4-4b19-aae1-c0b7ff1a942a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-75ba12c
image: gcr.io/agones-images/agones-sdk:1.6.0-75ba12c
image: gcr.io/agones-images/agones-ping:1.6.0-75ba12c
Linux C++ SDK (build): agonessdk-1.6.0-75ba12c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-75ba12c.zip

A preview of the website (the last 30 builds are retained):

https://75ba12c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1471/head:pr_1471 && git checkout pr_1471
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-75ba12c

* Added pull request template fix * Removed api-change label * Removed release and design label Removed design label Co-authored-by: Mark Mandel <markmandel@google.com>

google-oss-robot requested review from cyriltovena and pooneh-m April 14, 2020 14:44

google-oss-robot added the size/M label Apr 14, 2020

aLekSer reviewed Apr 14, 2020

View reviewed changes

google-oss-robot assigned thisisnotapril Apr 14, 2020

roberthbailey reviewed Apr 17, 2020

View reviewed changes

alexey-kremsa-globant added 3 commits April 17, 2020 21:52

Added pull request template

70626ab

fix

Removed api-change label

c98c0ce

Removed release and design label

06d9072

Removed design label

akremsa force-pushed the pr-template branch from 1829090 to 06d9072 Compare April 17, 2020 18:52

google-oss-robot added size/S and removed size/M labels Apr 17, 2020

markmandel approved these changes Apr 18, 2020

View reviewed changes

google-oss-robot assigned markmandel Apr 18, 2020

google-oss-robot added the lgtm label Apr 18, 2020

google-oss-robot added the approved label Apr 18, 2020

markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/feature New features for Agones labels Apr 18, 2020

markmandel added this to the 1.6.0 milestone Apr 18, 2020

Merge branch 'master' into pr-template

75ba12c

google-oss-robot removed the lgtm label Apr 18, 2020

markmandel merged commit c96f551 into googleforgames:master Apr 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a pull request template #1471

Added a pull request template #1471

akremsa commented Apr 14, 2020

agones-bot commented Apr 14, 2020

aLekSer commented Apr 14, 2020

aLekSer Apr 14, 2020 •

edited

markmandel Apr 16, 2020

markmandel Apr 16, 2020

akremsa Apr 16, 2020

roberthbailey commented Apr 14, 2020

agones-bot commented Apr 16, 2020

agones-bot commented Apr 16, 2020

roberthbailey Apr 17, 2020

agones-bot commented Apr 17, 2020

agones-bot commented Apr 17, 2020

markmandel left a comment

google-oss-robot commented Apr 18, 2020

google-oss-robot commented Apr 18, 2020

agones-bot commented Apr 18, 2020

Added a pull request template #1471

Added a pull request template #1471

Conversation

akremsa commented Apr 14, 2020

agones-bot commented Apr 14, 2020

aLekSer commented Apr 14, 2020

aLekSer Apr 14, 2020 • edited

Choose a reason for hiding this comment

markmandel Apr 16, 2020

Choose a reason for hiding this comment

markmandel Apr 16, 2020

Choose a reason for hiding this comment

akremsa Apr 16, 2020

Choose a reason for hiding this comment

roberthbailey commented Apr 14, 2020

agones-bot commented Apr 16, 2020

agones-bot commented Apr 16, 2020

roberthbailey Apr 17, 2020

Choose a reason for hiding this comment

agones-bot commented Apr 17, 2020

agones-bot commented Apr 17, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 18, 2020

google-oss-robot commented Apr 18, 2020

agones-bot commented Apr 18, 2020

aLekSer Apr 14, 2020 •

edited