New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a pull request template #1471
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| <!-- Thanks for sending a pull request! Here are some tips for you: | ||
|
|
||
| 1. If this is your first time, please read our contributor guidelines: https://github.com/googleforgames/agones/blob/master/CONTRIBUTING.md and developer guide https://github.com/googleforgames/agones/blob/master/build/README.md | ||
| 2. Please label this pull request according to what type of issue you are addressing. | ||
| 3. Ensure you have added or ran the appropriate tests for your PR: https://github.com/googleforgames/agones/blob/master/build/README.md#testing-and-building | ||
| --> | ||
|
|
||
| **What type of PR is this?** | ||
| > Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespace from that line: | ||
| > | ||
| > /kind breaking | ||
| > /kind bug | ||
| > /kind cleanup | ||
| > /kind documentation | ||
| > /kind feature | ||
| > /kind hotfix | ||
|
|
||
| **What this PR does / Why we need it**: | ||
|
|
||
| **Which issue(s) this PR fixes**: | ||
| <!-- | ||
| *Automatically closes linked issue when PR is merged. | ||
| Usage: `Closes #<issue number>`, or `Closes (paste link of issue)`. | ||
| --> | ||
| Closes # | ||
|
|
||
| **Special notes for your reviewer**: | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally prefer fixes to closes, but according to https://help.github.com/en/enterprise/2.16/user/github/managing-your-work-on-github/closing-issues-using-keywords both do the same thing.