Remove node_name label from allocation metrics

[yoshd]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Remove the node_name label from agones_gameserver_allocations_duration.

Which issue(s) this PR fixes: #2424

Special notes for your reviewer:

This is the response before the /metrics API was fixed:

# on my local minikube
agones_gameserver_allocations_duration_seconds_bucket{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",node_name="minikube",scheduling_strategy="Packed",status="Allocated",le="0.01"} 0
...
agones_gameserver_allocations_duration_seconds_bucket{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",node_name="minikube",scheduling_strategy="Packed",status="Allocated",le="+Inf"} 2
agones_gameserver_allocations_duration_seconds_sum{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",node_name="minikube",scheduling_strategy="Packed",status="Allocated"} 0.594067538
agones_gameserver_allocations_duration_seconds_count{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",node_name="minikube",scheduling_strategy="Packed",status="Allocated"} 2

After:

# on my local minikube
agones_gameserver_allocations_duration_seconds_bucket{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",scheduling_strategy="Packed",status="Allocated",le="0.01"} 0
...
agones_gameserver_allocations_duration_seconds_bucket{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",scheduling_strategy="Packed",status="Allocated",le="+Inf"} 1
agones_gameserver_allocations_duration_seconds_sum{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",scheduling_strategy="Packed",status="Allocated"} 0.512152551
agones_gameserver_allocations_duration_seconds_count{cluster_name="none",fleet_name="simple-game-server",is_multicluster="false",scheduling_strategy="Packed",status="Allocated"} 1

The "Allocations rate per node" graph in the Grafana dashboard used to use the node_name label, but I removed it because I don't think this graph is very useful.

[yoshd]

/assign @pooneh-m

[agones-bot]

Build Failed 😱

Build Id: 5331cb0e-71ac-495a-8970-c0700b87821c

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

One day we will resolve the flake in make run-sdk-conformance-test-cpp

[markmandel]

Oh nice, you did the grafana one too. I'll find some time to spin up the new dashboards and confirm, and we'll get this in the new release 👍🏻

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, yoshd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markmandel]

Had a look at the grafana dashboard, all looks good 👍🏻

[agones-bot]

Build Failed 😱

Build Id: 9fff4bf5-e228-4b6b-915c-f6e97eae53b2

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 3558a321-a8a0-4190-bb5d-f0ed46d7b33d

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.21.0-851a1ff
• image: gcr.io/agones-images/agones-ping:1.21.0-851a1ff
• Linux C++ SDK (build): agonessdk-1.21.0-851a1ff-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.21.0-851a1ff.zip

A preview of the website (the last 30 builds are retained):

• https://851a1ff-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2433/head:pr_2433 && git checkout pr_2433
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-851a1ff