Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE Autopilot: Add terraform module, users #2912

Merged
merged 2 commits into from
Jan 24, 2023

Conversation

zmerlynn
Copy link
Collaborator

This adds an install/terraform module names gke-autopilot, example terraform submodule, build submodule, e2e submodule and e2e Makefile targets for GKE Autopilot.

I did not add additional Makefile targets - we can do those as needed, but there do seem to be a group of other targets that use the gke module.

Towards #2777

@zmerlynn zmerlynn force-pushed the add-autopilot-to-terraform branch 2 times, most recently from c793e1e to 118f0c0 Compare January 19, 2023 01:05
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: d8c16d28-3421-49a7-ad9b-02128c7df41f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.29.0-d7af1ff-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8b701bba-2f81-45c5-8fc9-dbc45975ce49

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f58333cb-3194-457e-9e78-0f2af2602d8c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: cc3f0dcf-1fed-4f58-838b-8ca704635b15

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-e164cac-amd64

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: e1ec9e15-d463-4462-a611-58cdd7efbeef

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9159120c-d51b-4701-81a4-36e3b78dff0a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6687cc8-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4496f833-3984-41ef-a5af-9ab869b4ea04

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-6082b85-amd64

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 088caa80-6227-48ea-a099-77d5ba6e8676

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-413dfe7-amd64

build/terraform/e2e/module.tf Show resolved Hide resolved
install/terraform/modules/gke-autopilot/variables.tf Outdated Show resolved Hide resolved
build/terraform/gke-autopilot/module.tf Show resolved Hide resolved
// Run:
// terraform apply -var project="<YOUR_GCP_ProjectID>" [-var agones_version="1.30.0"]

terraform {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to have a following up PR to include the instruction about the usage or this Module? I assume that will be something like this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - it's going out in a broader set of doc updates when we work out how we want to structure it.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 76ce772b-0a3b-4e4a-8e2a-b5780ab88da8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 24, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gongmax, zmerlynn
Once this PR has been reviewed and has the lgtm label, please ask for approval from markmandel by writing /assign @markmandel in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 24, 2023
@zmerlynn zmerlynn enabled auto-merge (squash) January 24, 2023 17:31
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 8c7bfb9d-51e8-4579-a3fb-4bbfa6087aa0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 01b25724-538a-4a47-80a3-7e0beecd4db1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-b50e320-amd64

… for multi-cluster

* Adds install/terraform/modules/gke-autopilot module, based on modules/gke
* Adds example module (will document)
* Refactors e2es, based on discussions with @gongmax: now the
top-level e2e module is the "project" module for the whole e2e
project, with additional gke-autopilot and gke-standard modules
underneath as "per-cluster" modules.
* Allows firewall creation to be handled in project module.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a6f9bfdb-cb4e-47ee-9fa5-358b8a531b8d

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2912/head:pr_2912 && git checkout pr_2912
  • helm install agones ./install/helm/agones --namespace agones-system --agones.image.release=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.30.0-2bfdf14-amd64

@zmerlynn zmerlynn merged commit 45d26e8 into googleforgames:main Jan 24, 2023
@zmerlynn zmerlynn deleted the add-autopilot-to-terraform branch January 25, 2023 22:21
igooch pushed a commit to igooch/agones that referenced this pull request Jan 31, 2023
* GKE Terraform: Add Autopilot terraform module, refactor e2e terraform for multi-cluster

* Adds install/terraform/modules/gke-autopilot module, based on modules/gke
* Adds example module (will document)
* Refactors e2es, based on discussions with @gongmax: now the
top-level e2e module is the "project" module for the whole e2e
project, with additional gke-autopilot and gke-standard modules
underneath as "per-cluster" modules.
* Allows firewall creation to be handled in project module.
@Kalaiselvi84 Kalaiselvi84 added this to the 1.30.0 milestone Feb 28, 2023
@Kalaiselvi84 Kalaiselvi84 added the kind/feature New features for Agones label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants