-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Counters and Lists: Remove Bool Returns #3738
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0ae2d9c
Counters and Lists Methods: Remove Boolean Returns
Kalaiselvi84 b89c673
change in main.go and gameserver_test.go
Kalaiselvi84 5b644a8
Modify incrementCounter
Kalaiselvi84 5c2d4b3
change project name
Kalaiselvi84 542188c
update sdk-client-test.go
Kalaiselvi84 e303e6f
C-L methods: remove bool returns
Kalaiselvi84 bf36272
Merge branch 'main' into cl-rm-bool
Kalaiselvi84 a628dcc
project update
Kalaiselvi84 545a95b
error string should not start with uppercase
Kalaiselvi84 61b137c
change err to nil
Kalaiselvi84 f10ba34
Merge branch 'cl-rm-bool' of https://github.com/Kalaiselvi84/agones i…
Kalaiselvi84 af55624
Merge branch 'main' into cl-rm-bool
Kalaiselvi84 73f5dde
Bump simple-game-server image
Kalaiselvi84 7081403
Merge branch 'main' into cl-rm-bool
Kalaiselvi84 50a357f
Merge branch 'main' into cl-rm-bool
Kalaiselvi84 2062134
SUCCESS response update: remove ACK and include new line
Kalaiselvi84 0710b86
Merge branch 'main' into cl-rm-bool
zmerlynn 4ff3973
bump sgs:0.30
Kalaiselvi84 1049c50
Merge branch 'cl-rm-bool' of https://github.com/Kalaiselvi84/agones i…
Kalaiselvi84 788f7be
Merge branch 'main' into cl-rm-bool
Kalaiselvi84 1f54fd3
Merge branch 'main' into cl-rm-bool
zmerlynn 8e6d7b3
remove bool from fleet_test.com
Kalaiselvi84 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
addACK = true
then any response will start with "ACK" which why we're seeingactual : "ACK: SUCCESS\n"
as the result.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't made any modifications to the value of this
addACK
.Here's the code snippet:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's in the case where there is an error. In the case where there is no error it returns the default
addACK = true
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I understand this part, when there is no error, the default value will be
addAck = true
.Sorry, I want to make sure I get it right. Could you please share your suggestion differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @igooch is saying that when you look at the e2e tests:
The reason that the actual response is
ACK: SUCCESS
, is because you removed the lineaddACK = false
-- whereas it should remain in to remove the "ACK: " from the response we're seeing in e2e tests (and I expect locally as well).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good pickup @igooch - I didn't see the "ACK: SUCCESS" output in #3738 (comment) - whereas the output should just be "SUCCESS".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for explaining. I've made changes to the code in the main.go and gameserver_test.go files. Please review the testing for the success use case. Once you both confirm the changes, will push a new image to production.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igooch I look forward to hearing your thoughts at your convenience!🙂