Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fleet RollingUpdate strategy params validation #808

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Add Fleet RollingUpdate strategy params validation #808

merged 1 commit into from
Jun 5, 2019

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Jun 5, 2019

Need to have only values over 0%, otherwise no rolling update would occur.

@aLekSer
Add Fleet RollingUpdate strategy params validation
45600df 
Need to have only values over 0%, otherwise no rolling update would
occur.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f0db44f6-a176-4962-99c6-0abba588e115

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/808/head:pr_808 && git checkout pr_808
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-45600df

markmandel
markmandel approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! 👍

@markmandel markmandel merged commit 84bf6c1 into googleforgames:master Jun 5, 2019
aLekSer added a commit to aLekSer/agones that referenced this pull request Jun 6, 2019
@aLekSer
Add Fleet RollingUpdate strategy params validation (googleforgames#808)
bca4f87 
Need to have only values over 0%, otherwise no rolling update would
occur.
@markmandel markmandel added this to the 0.11.0 milestone Jun 12, 2019
@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones labels Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/feature New features for Agones
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aLekSer @agones-bot @markmandel