Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the stable api group and promote it to v1 #894

Merged
merged 14 commits into from Jul 17, 2019

Conversation

@roberthbailey
Copy link
Member

commented Jul 10, 2019

I wanted to get the first part of this out for folks to look at before I go through all of the docs and install bits and get them updated. I've done the package move and version change and fixed enough of the code to get the unit tests to pass.

Part of #703.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 10, 2019

Build Failed 😱

Build Id: ee19a6c6-008c-4270-953d-72dd1f513696

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch 2 times, most recently from e553164 to 3ba3196 Jul 12, 2019

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

The newest push has the a bunch of the remaining bits updated (I think all that remains is the docs). I've done a first pass on the SDKs, but I still need to figure out how to test them more thoroughly, since it seems like make test-sdks only tests the go and node SDKs.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Build Failed 😱

Build Id: a00e7ddb-460f-495a-a08c-6e821671753a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Build Failed 😱

Build Id: 7265be7c-c666-4c4a-bb5e-750dc052b5a5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from 3ba3196 to aa72061 Jul 12, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Build Failed 😱

Build Id: 2ea8355b-6122-4983-9bba-fc21f522e365

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from aa72061 to b80766b Jul 12, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Build Failed 😱

Build Id: 3eaf4a79-b4d5-4d7a-89fa-02aeaa60e3ed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from b80766b to 486fcfd Jul 12, 2019

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Had a quick look through - approach looks good. Not seeing any red flags on my end 👍

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Build Failed 😱

Build Id: 4968f309-4984-47cd-a379-b0636e9679e7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from 486fcfd to 4c3cb10 Jul 13, 2019

@roberthbailey roberthbailey marked this pull request as ready for review Jul 13, 2019

@roberthbailey
Copy link
Member Author

left a comment

I've finished going through all of the docs and updating them. This PR won't pass tests until we delete the helm install (like the previous breaking changes) but I'm wondering.... once we do that will all other PRs fail tests until they rebase on top of this one?

I'm happy to let this sit for a couple of days while we merge other PRs to prevent other contributors from having to rebase, since this is likely to force every other PR to need a rebase, but it would be nice to get it in before the end of next week so that I don't have to rebase it for too long.

@@ -29,7 +29,7 @@
[5.890398, "o", "\u001b[?1l\u001b>\u001b[?2004l\r\r\n"]
[5.891151, "o", "\u001b]2;kubectl apply -f fleet.yaml\u0007\u001b]1;kubectl\u0007"]
[5.891306, "o", "\u001b]133;C;\u0007"]
[6.329093, "o", "fleet.stable.agones.dev/simple-udp created\r\n"]
[6.329093, "o", "fleet.agones.dev/simple-udp created\r\n"]

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 13, 2019

Author Member

I'm not sure whether the feature flag things work in this file....

This comment has been minimized.

Copy link
@cyriltovena

cyriltovena Jul 15, 2019

Collaborator

this file is interpreted by javascript to render the cast.

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 15, 2019

Author Member

I wasn't sure how to fix it properly. One option is just put this into a separate PR and merge it right before we cut 0.12.0 so that the website flips is only different from the latest release for a short period of time.

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 15, 2019

Author Member

I've moved this change into #911.

This comment has been minimized.

Copy link
@cyriltovena

cyriltovena Jul 16, 2019

Collaborator

awesome.

@@ -236,7 +293,6 @@ $ curl http://localhost:8001/apis/stable.agones.dev/v1alpha1/namespaces/default/
# allocate a gameserver from a fleet named 'simple-udp', with GameServerAllocation
{{% feature expiryVersion="0.12.0" %}}

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 13, 2019

Author Member

This looks a bit funny, but I split all of the new stuff into a different block so that it's easier to see what changed.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2019

Build Failed 😱

Build Id: e0c313f3-7b37-43fa-b0e4-c148b26a0c8c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from 4c3cb10 to 92b8557 Jul 15, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Build Failed 😱

Build Id: 78b025a6-035f-4d3c-8175-24f1650a2d01

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from 92b8557 to 780ca22 Jul 15, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Build Failed 😱

Build Id: 5f7a04a9-ae26-4511-839b-9b845070b7bf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from 780ca22 to d5518d2 Jul 15, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Build Failed 😱

Build Id: d16836d2-54ec-47d7-8e90-b7e5df08caf6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@@ -4,7 +4,12 @@ linkTitle: "Create an Allocator Service (Go)"
date: 2019-01-03T03:15:34Z
description: >
This tutorial describes how to interact programmatically with the
{{% feature expiryVersion="0.12.0" %}}

This comment has been minimized.

Copy link
@roberthbailey

roberthbailey Jul 15, 2019

Author Member

It looks like I can't use the curly braces in the yaml part here, since it causes the tests to fail. So I'm going to leave this with the v1alpha1 version and we'll need to change it around the time we cut the 0.12.0 release.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch 2 times, most recently from 82c8220 to 8d01dfe Jul 15, 2019

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Build Failed 😱

Build Id: a3f92ffd-f8a1-482c-80b7-b617b8f29fa2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 15, 2019

Build Failed 😱

Build Id: eeb06864-93f3-4134-ad60-0c4ee17f94c2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@cyriltovena
Copy link
Collaborator

left a comment

LGTM. Should we merge tomorrow ?

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 16, 2019

LGTM. Should we merge tomorrow ?

I'm wondering if we should get @markmandel's PR for the Reserve() SDK in first, since this is going to conflict and I'm happy to do the resolving on my end. Once that one is in I don't see nearly as many open PRs that will conflict so it'd probably be a good time to do it.

@roberthbailey roberthbailey force-pushed the roberthbailey:stable-to-core-v1 branch from 5f47824 to 554bc72 Jul 17, 2019

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

I added a commit that I think will make e2e pass, but I should also run through the other examples and see if they need a recompile / image update as well.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

Good point - they probably do.

@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

/cc @aLekSer will this affect the conformance tests?

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

Build Failed 😱

Build Id: e65add73-fdef-4365-9841-1d87af6daacb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

Build Failed 😱

Build Id: d803b573-e5cb-4820-82b1-5ff9a4b0748a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

The latest build failed during the helm upgrade

Error: UPGRADE FAILED: MutatingWebhookConfiguration.admissionregistration.k8s.io "agones-mutation-webhook" is invalid: webhooks[0].clientConfig.url: Required value: exactly one of url or service is required && ValidatingWebhookConfiguration.admissionregistration.k8s.io "agones-validation-webhook" is invalid: webhooks[0].clientConfig.url: Required value: exactly one of url or service is required
make: *** [install] Error 1
Makefile:277: recipe for target 'install' failed

I'm going to restart it and see if we can get a signal from the sdk conformance tests.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

Build Failed 😱

Build Id: bf136040-bd3b-403f-83be-54e57a9bc338

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

Regarding conformance tests I don't see any issues. Let see if they pass on Cloud Build.

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

The conformance tests are passing locally for me; hopefully they also pass in CI.

@agones-bot

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

Build Succeeded 👏

Build Id: 9c790210-4bbc-4259-8c2e-ab9e6bd30891

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/894/head:pr_894 && git checkout pr_894
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-554bc72

@markmandel markmandel merged commit d6cb007 into googleforgames:master Jul 17, 2019

2 checks passed

agones-bot Build 9c790210-4bbc-4259-8c2e-ab9e6bd30891 succeeded
Details
cla/google All necessary CLAs are signed
@markmandel

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2019

xug5ger

@roberthbailey

This comment has been minimized.

Copy link
Member Author

commented Jul 17, 2019

Regarding:

I think for now to unstick us, create a 0.12 manually and push it up, and we'll come up with a more formal process later. WDYT?

I've created #917. And in the meantime, I've rebuilt the container image from the master branch and pushed it.

@roberthbailey roberthbailey deleted the roberthbailey:stable-to-core-v1 branch Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.