Move the stable api group and promote it to v1 #894

roberthbailey · 2019-07-10T19:35:12Z

I wanted to get the first part of this out for folks to look at before I go through all of the docs and install bits and get them updated. I've done the package move and version change and fixed enough of the code to get the unit tests to pass.

Part of #703.

agones-bot · 2019-07-10T19:39:12Z

Build Failed 😱

Build Id: ee19a6c6-008c-4270-953d-72dd1f513696

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-07-12T09:53:29Z

The newest push has the a bunch of the remaining bits updated (I think all that remains is the docs). I've done a first pass on the SDKs, but I still need to figure out how to test them more thoroughly, since it seems like make test-sdks only tests the go and node SDKs.

agones-bot · 2019-07-12T09:56:51Z

Build Failed 😱

Build Id: a00e7ddb-460f-495a-a08c-6e821671753a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-12T09:58:16Z

Build Failed 😱

Build Id: 7265be7c-c666-4c4a-bb5e-750dc052b5a5

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-12T22:04:44Z

Build Failed 😱

Build Id: 2ea8355b-6122-4983-9bba-fc21f522e365

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-12T22:41:57Z

Build Failed 😱

Build Id: 3eaf4a79-b4d5-4d7a-89fa-02aeaa60e3ed

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2019-07-12T23:12:05Z

Had a quick look through - approach looks good. Not seeing any red flags on my end 👍

agones-bot · 2019-07-12T23:18:54Z

Build Failed 😱

Build Id: 4968f309-4984-47cd-a379-b0636e9679e7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey

I've finished going through all of the docs and updating them. This PR won't pass tests until we delete the helm install (like the previous breaking changes) but I'm wondering.... once we do that will all other PRs fail tests until they rebase on top of this one?

I'm happy to let this sit for a couple of days while we merge other PRs to prevent other contributors from having to rebase, since this is likely to force every other PR to need a rebase, but it would be nice to get it in before the end of next week so that I don't have to rebase it for too long.

roberthbailey · 2019-07-13T08:15:44Z

site/static/agones.cast

@@ -29,7 +29,7 @@
 [5.890398, "o", "\u001b[?1l\u001b>\u001b[?2004l\r\r\n"]
 [5.891151, "o", "\u001b]2;kubectl apply -f fleet.yaml\u0007\u001b]1;kubectl\u0007"]
 [5.891306, "o", "\u001b]133;C;\u0007"]
-[6.329093, "o", "fleet.stable.agones.dev/simple-udp created\r\n"]
+[6.329093, "o", "fleet.agones.dev/simple-udp created\r\n"]


I'm not sure whether the feature flag things work in this file....

this file is interpreted by javascript to render the cast.

I wasn't sure how to fix it properly. One option is just put this into a separate PR and merge it right before we cut 0.12.0 so that the website flips is only different from the latest release for a short period of time.

I've moved this change into #911.

roberthbailey · 2019-07-13T08:16:45Z

site/content/en/docs/Guides/access-api.md

@@ -236,7 +293,6 @@ $ curl http://localhost:8001/apis/stable.agones.dev/v1alpha1/namespaces/default/

 # allocate a gameserver from a fleet named 'simple-udp', with GameServerAllocation

-{{% feature expiryVersion="0.12.0" %}}


This looks a bit funny, but I split all of the new stuff into a different block so that it's easier to see what changed.

agones-bot · 2019-07-13T08:40:30Z

Build Failed 😱

Build Id: e0c313f3-7b37-43fa-b0e4-c148b26a0c8c

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-15T07:50:21Z

Build Failed 😱

Build Id: 78b025a6-035f-4d3c-8175-24f1650a2d01

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-15T21:59:10Z

Build Failed 😱

Build Id: 5f7a04a9-ae26-4511-839b-9b845070b7bf

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-15T22:31:39Z

Build Failed 😱

Build Id: d16836d2-54ec-47d7-8e90-b7e5df08caf6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-07-15T22:41:32Z

site/content/en/docs/Tutorials/allocator-service-go.md

@@ -4,7 +4,12 @@ linkTitle: "Create an Allocator Service (Go)"
 date: 2019-01-03T03:15:34Z
 description: >
  This tutorial describes how to interact programmatically with the 
+{{% feature expiryVersion="0.12.0" %}}


It looks like I can't use the curly braces in the yaml part here, since it causes the tests to fail. So I'm going to leave this with the v1alpha1 version and we'll need to change it around the time we cut the 0.12.0 release.

agones-bot · 2019-07-15T23:09:31Z

Build Failed 😱

Build Id: a3f92ffd-f8a1-482c-80b7-b617b8f29fa2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-15T23:17:46Z

Build Failed 😱

Build Id: eeb06864-93f3-4134-ad60-0c4ee17f94c2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

cyriltovena

LGTM. Should we merge tomorrow ?

roberthbailey · 2019-07-16T04:07:58Z

LGTM. Should we merge tomorrow ?

I'm wondering if we should get @markmandel's PR for the Reserve() SDK in first, since this is going to conflict and I'm happy to do the resolving on my end. Once that one is in I don't see nearly as many open PRs that will conflict so it'd probably be a good time to do it.

changes to the SDK.

roberthbailey · 2019-07-17T17:20:39Z

I added a commit that I think will make e2e pass, but I should also run through the other examples and see if they need a recompile / image update as well.

markmandel · 2019-07-17T17:27:28Z

Good point - they probably do.

markmandel · 2019-07-17T17:31:11Z

/cc @aLekSer will this affect the conformance tests?

agones-bot · 2019-07-17T17:37:07Z

Build Failed 😱

Build Id: e65add73-fdef-4365-9841-1d87af6daacb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-07-17T17:37:53Z

Build Failed 😱

Build Id: d803b573-e5cb-4820-82b1-5ff9a4b0748a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2019-07-17T17:38:57Z

The latest build failed during the helm upgrade

Error: UPGRADE FAILED: MutatingWebhookConfiguration.admissionregistration.k8s.io "agones-mutation-webhook" is invalid: webhooks[0].clientConfig.url: Required value: exactly one of url or service is required && ValidatingWebhookConfiguration.admissionregistration.k8s.io "agones-validation-webhook" is invalid: webhooks[0].clientConfig.url: Required value: exactly one of url or service is required
make: *** [install] Error 1
Makefile:277: recipe for target 'install' failed

I'm going to restart it and see if we can get a signal from the sdk conformance tests.

agones-bot · 2019-07-17T18:05:23Z

Build Failed 😱

Build Id: bf136040-bd3b-403f-83be-54e57a9bc338

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

aLekSer · 2019-07-17T18:30:15Z

Regarding conformance tests I don't see any issues. Let see if they pass on Cloud Build.

roberthbailey · 2019-07-17T18:56:58Z

The conformance tests are passing locally for me; hopefully they also pass in CI.

agones-bot · 2019-07-17T19:05:52Z

Build Succeeded 👏

Build Id: 9c790210-4bbc-4259-8c2e-ab9e6bd30891

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-554bc72
image: gcr.io/agones-images/agones-sdk:0.12.0-554bc72
image: gcr.io/agones-images/agones-ping:0.12.0-554bc72
Linux C++ SDK (build): agonessdk-0.12.0-554bc72-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-554bc72.zip

A preview of the website (the last 30 builds are retained):

https://554bc72-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/894/head:pr_894 && git checkout pr_894
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-554bc72

markmandel · 2019-07-17T19:13:55Z

roberthbailey · 2019-07-17T20:04:00Z

Regarding:

I think for now to unstick us, create a 0.12 manually and push it up, and we'll come up with a more formal process later. WDYT?

I've created #917. And in the meantime, I've rebuilt the container image from the master branch and pushed it.

roberthbailey force-pushed the stable-to-core-v1 branch 2 times, most recently from e553164 to 3ba3196 Compare July 12, 2019 09:50

roberthbailey force-pushed the stable-to-core-v1 branch from 3ba3196 to aa72061 Compare July 12, 2019 21:36

roberthbailey force-pushed the stable-to-core-v1 branch from aa72061 to b80766b Compare July 12, 2019 22:15

roberthbailey force-pushed the stable-to-core-v1 branch from b80766b to 486fcfd Compare July 12, 2019 22:50

roberthbailey force-pushed the stable-to-core-v1 branch from 486fcfd to 4c3cb10 Compare July 13, 2019 08:14

roberthbailey marked this pull request as ready for review July 13, 2019 08:17

roberthbailey commented Jul 13, 2019

View reviewed changes

roberthbailey force-pushed the stable-to-core-v1 branch from 4c3cb10 to 92b8557 Compare July 15, 2019 07:24

roberthbailey force-pushed the stable-to-core-v1 branch from 92b8557 to 780ca22 Compare July 15, 2019 21:33

roberthbailey force-pushed the stable-to-core-v1 branch from 780ca22 to d5518d2 Compare July 15, 2019 22:03

roberthbailey commented Jul 15, 2019

View reviewed changes

roberthbailey force-pushed the stable-to-core-v1 branch 2 times, most recently from 82c8220 to 8d01dfe Compare July 15, 2019 22:48

cyriltovena approved these changes Jul 16, 2019

View reviewed changes

roberthbailey added 13 commits July 17, 2019 10:11

Code updated for the new agones core api import path.

0bd298f

Run make gen-crd-client.

4ce3ee1

Force a rebuild of the build image.

e5b520c

Update the examples directory for the new allocation api version.

9a96d11

Update the install/helm directory for the new allocation api version.

399ad76

Run make gen-install.

f401d55

Update the build directory for the new allocation api version.

e2ebf10

Updates to the sdk proto. Also ran make gen-sdk-grpc.

13fc0e7

Run make gen-all-sdk-grpc.

6c8e352

Manual fixes to the cpp sdk.

0000a67

Update website docs.

b6094e7

Run make gen-api-docs.

171a5de

Update the version of the simple-udp container image to pick up the

554bc72

changes to the SDK.

roberthbailey force-pushed the stable-to-core-v1 branch from 5f47824 to 554bc72 Compare July 17, 2019 17:11

markmandel merged commit d6cb007 into googleforgames:master Jul 17, 2019

roberthbailey mentioned this pull request Jul 17, 2019

Process for pushing container images to gcr.io/agones-images #917

Closed

markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 1, 2019

roberthbailey deleted the stable-to-core-v1 branch August 1, 2019 16:27

		@@ -236,7 +293,6 @@ $ curl http://localhost:8001/apis/stable.agones.dev/v1alpha1/namespaces/default/

		# allocate a gameserver from a fleet named 'simple-udp', with GameServerAllocation

		{{% feature expiryVersion="0.12.0" %}}

Move the stable api group and promote it to v1 #894

Move the stable api group and promote it to v1 #894

Conversation

roberthbailey commented Jul 10, 2019 • edited Loading

agones-bot commented Jul 10, 2019

roberthbailey commented Jul 12, 2019

agones-bot commented Jul 12, 2019

agones-bot commented Jul 12, 2019

agones-bot commented Jul 12, 2019

agones-bot commented Jul 12, 2019

markmandel commented Jul 12, 2019

agones-bot commented Jul 12, 2019

roberthbailey left a comment

Choose a reason for hiding this comment

roberthbailey Jul 13, 2019

Choose a reason for hiding this comment

cyriltovena Jul 15, 2019

Choose a reason for hiding this comment

roberthbailey Jul 15, 2019

Choose a reason for hiding this comment

roberthbailey Jul 15, 2019

Choose a reason for hiding this comment

cyriltovena Jul 16, 2019

Choose a reason for hiding this comment

roberthbailey Jul 13, 2019

Choose a reason for hiding this comment

agones-bot commented Jul 13, 2019

agones-bot commented Jul 15, 2019

agones-bot commented Jul 15, 2019

agones-bot commented Jul 15, 2019

roberthbailey Jul 15, 2019

Choose a reason for hiding this comment

agones-bot commented Jul 15, 2019

agones-bot commented Jul 15, 2019

cyriltovena left a comment

Choose a reason for hiding this comment

roberthbailey commented Jul 16, 2019

roberthbailey commented Jul 17, 2019

markmandel commented Jul 17, 2019

markmandel commented Jul 17, 2019

agones-bot commented Jul 17, 2019

agones-bot commented Jul 17, 2019

roberthbailey commented Jul 17, 2019

agones-bot commented Jul 17, 2019

aLekSer commented Jul 17, 2019

roberthbailey commented Jul 17, 2019

agones-bot commented Jul 17, 2019

markmandel commented Jul 17, 2019

roberthbailey commented Jul 17, 2019

roberthbailey commented Jul 10, 2019 •

edited

Loading