Updates to the rust simple example. #937

roberthbailey · 2019-07-22T18:28:19Z

Fixes #703.

I re-ordered things into what I thought was a more useful ordering (less work -- cloud -- to more work -- local dev environment) and made it so that we could push an "official" image to the agones-images project so that you can run the example without needing to compile any code.

One thing that is weird is that while the running locally with docker instructions work for me, when I run the sample in an actual GKE cluster the game server never moves to Ready -- even though the sidecar is getting health pings the game server never transitions out of the unhealthy state. Maybe @aLekSer has an idea of why this might be?

aLekSer · 2019-07-22T18:56:09Z

Re GKE cluster I cannot find any images under
https://console.cloud.google.com/gcr/images/agones-images/GLOBAL/rust-simple-server?gcrImageListsize=30

agones-bot · 2019-07-22T19:02:03Z

Build Succeeded 👏

Build Id: cbcfcd65-c425-4bd8-97b2-42c8a29a96e9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-c1dd21f
image: gcr.io/agones-images/agones-sdk:0.12.0-c1dd21f
image: gcr.io/agones-images/agones-ping:0.12.0-c1dd21f
Linux C++ SDK (build): agonessdk-0.12.0-c1dd21f-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-c1dd21f.zip

A preview of the website (the last 30 builds are retained):

https://c1dd21f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-c1dd21f

roberthbailey · 2019-07-22T22:00:23Z

@aLekSer - there aren't any images there (yet). I've been testing with images in my own project so that I only push images to the official project once the code has been reviewed.

From https://github.com/googleforgames/agones/blob/c1dd21fb90fc7b9c8ee9515789c1e2dd51e00830/examples/rust-simple/README.md:

If you want to build your own image

$ REPOSITORY=<your-repository> # e.g. gcr.io/agones-images
$ make build-image REPOSITORY=${REPOSITORY}
$ docker push ${REPOSITORY}/rust-simple-server:0.3

To run your own image, make a copy of
examples/rust-simple/gameserver.yaml,
modify the image name to the image you pushed, and run kubectl create -f gameserver.yaml.

aLekSer · 2019-07-23T10:23:59Z

@roberthbailey thanks for clarification, just want to let you note that the original gcr.io/agones-images/rust-simple-server:0.3 should be pushed at some point for others to follow README.md.

roberthbailey · 2019-07-23T15:46:42Z

Definitely. I just want to make sure that it works first (right now it doesn't -- see #938).

aLekSer · 2019-07-23T16:03:34Z

Yes, I am new to Rust language that's why I can not provide a fix for #938 . Seems that it is needed to add some loop with sleep at the beginning on SDK connect stage.

markmandel

The cleanup here looks good - made one small comment similar to what I wrote on #934

I assume we aren't going to merge this until we fix #938 ?

markmandel · 2019-07-24T02:18:56Z

examples/rust-simple/README.md

 ```
-make run
+kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/rust-simple/gameserver.yaml


Same as the C++ one, should we make this

Suggested change

kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/rust-simple/gameserver.yaml

kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/<release-branch>/examples/rust-simple/gameserver.yaml

With a note saying "Where should match the Agones version you have deployed, e.g release-0.12"

Sound good?

roberthbailey · 2019-07-24T04:30:48Z

I assume we aren't going to merge this until we fix #938 ?

Yes. Unless it looks like it won't be fixed before the 0.12.0 release in which case I'll cut out the part about running in a cluster and replace it with a warning that the rust SDK is still experimental.

markmandel · 2019-07-25T11:11:39Z

Just to confirm - this is building now, but just isn't blocking? If that;s the case, I'll approve so we at least have an example that works.

roberthbailey · 2019-07-25T11:39:43Z

It builds and runs following the docs. But because the container doesn't block, when running the example on GKE the pod restarts and that means that the gameserver never becomes healthy.

agones-bot · 2019-07-25T12:11:40Z

Build Succeeded 👏

Build Id: 5bd8f31f-50d3-4681-8ba0-17e6e360059e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-94b06e8
image: gcr.io/agones-images/agones-sdk:0.12.0-94b06e8
image: gcr.io/agones-images/agones-ping:0.12.0-94b06e8
Linux C++ SDK (build): agonessdk-0.12.0-94b06e8-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-94b06e8.zip

A preview of the website (the last 30 builds are retained):

https://94b06e8-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-94b06e8

markmandel · 2019-07-25T21:38:37Z

Got it - thanks! I'll take a look, see if I can work out a quick solution as well. I've used rust before in a previous life, so hopefully it will come back to me 😄

Locally. I've got some changes to the conformance tests that will also check for the blocking functionality going forward.

roberthbailey · 2019-07-25T23:19:33Z

And running locally works just fine.

agones-bot · 2019-07-26T08:15:10Z

Build Succeeded 👏

Build Id: aaa95954-510a-4625-91e2-048be37209c9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-823c8b3
image: gcr.io/agones-images/agones-sdk:0.12.0-823c8b3
image: gcr.io/agones-images/agones-ping:0.12.0-823c8b3
Linux C++ SDK (build): agonessdk-0.12.0-823c8b3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-823c8b3.zip

A preview of the website (the last 30 builds are retained):

https://823c8b3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-823c8b3

markmandel · 2019-07-29T06:17:01Z

Once #953 is merged, this should be good to go.

roberthbailey · 2019-07-30T08:04:17Z

I'm going to re-work this to create a new tutorial like the cpp/nodejs ones. Changes should be ready shortly.

agones-bot · 2019-07-30T08:30:29Z

Build Succeeded 👏

Build Id: 503b34e3-0161-41c4-b738-79305fd96662

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-c971555
image: gcr.io/agones-images/agones-sdk:0.12.0-c971555
image: gcr.io/agones-images/agones-ping:0.12.0-c971555
Linux C++ SDK (build): agonessdk-0.12.0-c971555-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-c971555.zip

A preview of the website (the last 30 builds are retained):

https://c971555-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-c971555

agones-bot · 2019-07-30T09:20:21Z

Build Succeeded 👏

Build Id: 41281055-8cfb-4f75-a770-23ce3939ef97

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-eb08db4
image: gcr.io/agones-images/agones-sdk:0.12.0-eb08db4
image: gcr.io/agones-images/agones-ping:0.12.0-eb08db4
Linux C++ SDK (build): agonessdk-0.12.0-eb08db4-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-eb08db4.zip

A preview of the website (the last 30 builds are retained):

https://eb08db4-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-eb08db4

agones-bot · 2019-07-30T09:46:58Z

Build Succeeded 👏

Build Id: 754aae7f-2038-4b38-9c42-98290347c72f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-a8074c1
image: gcr.io/agones-images/agones-sdk:0.12.0-a8074c1
image: gcr.io/agones-images/agones-ping:0.12.0-a8074c1
Linux C++ SDK (build): agonessdk-0.12.0-a8074c1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-a8074c1.zip

A preview of the website (the last 30 builds are retained):

https://a8074c1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-a8074c1

markmandel · 2019-07-30T23:42:07Z

site/content/en/docs/Tutorials/simple-gameserver-rust.md

@@ -0,0 +1,203 @@
+---


I love these 💙

markmandel

agones-bot · 2019-07-31T00:20:33Z

Build Succeeded 👏

Build Id: bc509ca0-bf91-4c28-a3fe-04504b36dee0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.12.0-d13b61a
image: gcr.io/agones-images/agones-sdk:0.12.0-d13b61a
image: gcr.io/agones-images/agones-ping:0.12.0-d13b61a
Linux C++ SDK (build): agonessdk-0.12.0-d13b61a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-0.12.0-d13b61a.zip

A preview of the website (the last 30 builds are retained):

https://d13b61a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/937/head:pr_937 && git checkout pr_937
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-d13b61a

roberthbailey mentioned this pull request Jul 23, 2019

Rust SDK does not wait for connection to be ready #938

Closed

markmandel reviewed Jul 24, 2019

View reviewed changes

roberthbailey force-pushed the rust branch from c1dd21f to 94b06e8 Compare July 25, 2019 11:38

markmandel added area/examples Examples. Usually found in the `examples` directory kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 25, 2019

roberthbailey force-pushed the rust branch from 94b06e8 to 823c8b3 Compare July 26, 2019 07:41

roberthbailey mentioned this pull request Jul 26, 2019

Proposal: Split up the api group stable.agones.dev #703

Closed

roberthbailey force-pushed the rust branch from c971555 to eb08db4 Compare July 30, 2019 08:46

roberthbailey added this to the 0.12.0 milestone Jul 30, 2019

Updates to the rust simple example.

a8074c1

roberthbailey force-pushed the rust branch from eb08db4 to a8074c1 Compare July 30, 2019 09:12

roberthbailey assigned markmandel Jul 30, 2019

markmandel reviewed Jul 30, 2019

View reviewed changes

site/content/en/docs/Tutorials/simple-gameserver-rust.md

@@ -0,0 +1,203 @@

---

Copy link

Member

markmandel Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these 💙

markmandel approved these changes Jul 30, 2019

View reviewed changes

Merge branch 'master' into rust

d13b61a

markmandel merged commit 8de0dd9 into googleforgames:master Jul 31, 2019

roberthbailey deleted the rust branch August 1, 2019 16:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to the rust simple example. #937

Updates to the rust simple example. #937

roberthbailey commented Jul 22, 2019 •

edited

Loading

aLekSer commented Jul 22, 2019

agones-bot commented Jul 22, 2019

roberthbailey commented Jul 22, 2019

aLekSer commented Jul 23, 2019

roberthbailey commented Jul 23, 2019

aLekSer commented Jul 23, 2019

markmandel left a comment

markmandel Jul 24, 2019

roberthbailey commented Jul 24, 2019

markmandel commented Jul 25, 2019

roberthbailey commented Jul 25, 2019

agones-bot commented Jul 25, 2019

markmandel commented Jul 25, 2019

roberthbailey commented Jul 25, 2019

agones-bot commented Jul 26, 2019

markmandel commented Jul 29, 2019

roberthbailey commented Jul 30, 2019

agones-bot commented Jul 30, 2019

agones-bot commented Jul 30, 2019

agones-bot commented Jul 30, 2019

markmandel Jul 30, 2019

markmandel left a comment

agones-bot commented Jul 31, 2019

	kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/master/examples/rust-simple/gameserver.yaml
	kubectl create -f https://raw.githubusercontent.com/googleforgames/agones/<release-branch>/examples/rust-simple/gameserver.yaml

Updates to the rust simple example. #937

Updates to the rust simple example. #937

Conversation

roberthbailey commented Jul 22, 2019 • edited Loading

aLekSer commented Jul 22, 2019

agones-bot commented Jul 22, 2019

roberthbailey commented Jul 22, 2019

aLekSer commented Jul 23, 2019

roberthbailey commented Jul 23, 2019

aLekSer commented Jul 23, 2019

markmandel left a comment

Choose a reason for hiding this comment

markmandel Jul 24, 2019

Choose a reason for hiding this comment

roberthbailey commented Jul 24, 2019

markmandel commented Jul 25, 2019

roberthbailey commented Jul 25, 2019

agones-bot commented Jul 25, 2019

markmandel commented Jul 25, 2019

roberthbailey commented Jul 25, 2019

agones-bot commented Jul 26, 2019

markmandel commented Jul 29, 2019

roberthbailey commented Jul 30, 2019

agones-bot commented Jul 30, 2019

agones-bot commented Jul 30, 2019

agones-bot commented Jul 30, 2019

markmandel Jul 30, 2019

Choose a reason for hiding this comment

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jul 31, 2019

roberthbailey commented Jul 22, 2019 •

edited

Loading