This repository has been archived by the owner on Sep 15, 2021. It is now read-only.
Provide a better error for client-side shard filtering. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This yields a reasonable number of tasks for sharded jobs running over the whole genome.
Now that we are doing client-side filtering for strict shard boundaries, we need to check that we are requesting the field that the filter will require and return a useful error if not.
|
Nicole, I think it's ready to merge. I want to give it a try through Dataflow. Thanks, |
|
@calbach ptal when you have time? And let me know if you have an alternate suggestion for this check. |
|
Nicole, it's good enough. Just mention it in the Readme that you are being restrictive to generate uniqueness in the shards. Until we find a better solution - which would require some more deep thinking - let's just release it. Just provide something reasonable as a reason so users understand why. Paul |
| @Override | ||
| public void initialize(GenomicsRequest<?> search) { | ||
| if (null != fields) { | ||
| for (String requiredField : REQUIRED_STRICT_SHARD_FIELDS.keySet()) { |
There was a problem hiding this comment.
Perhaps this could be extracted to a common utility which accepts the fields string and the map of patterns to be matched.
calbach
added a commit
that referenced
this pull request
Mar 21, 2015
Provide a better error for client-side shard filtering.
|
Fantabulous - I love it! Thanks guys! Have a great weekend! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are doing client-side filtering for strict shard boundaries, we need to check that we are requesting the field that the filter will require and return a useful error if not.
Also increased the default number of bases per shard. This yields a reasonable number of tasks for sharded jobs running over the whole human genome.